Skip to content
This repository has been archived by the owner on Apr 4, 2023. It is now read-only.

Add GITHUB_TOKEN to GtiHub Workflow environment #797

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

azatsarynnyy
Copy link
Member

Signed-off-by: Artem Zatsarynnyi [email protected]

What does this PR do?

Sometimes, GtiHub Workflow fails with
Rate limit for https://api.github.com is reached.To be able to build this image, please provide GITHUB_TOKEN environment variable.
E.g. https://github.com/eclipse/che-theia/runs/849030227?check_suite_focus=true

This PR sets GITHUB_TOKEN env. var. through the secret.

What issues does this PR fix or reference?

Release Notes

Docs PR

@azatsarynnyy azatsarynnyy requested a review from benoitf as a code owner July 8, 2020 09:24
@vzhukovs
Copy link
Contributor

vzhukovs commented Jul 8, 2020

Just need to check if such secret exists in settings of current repository.

Link to the docs: https://docs.github.com/en/actions/configuring-and-managing-workflows/authenticating-with-the-github_token

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@azatsarynnyy
Copy link
Member Author

I just forgot to pass to build-args )

@azatsarynnyy
Copy link
Member Author

Hm... Can't figure out why it doesn't work as expected.
--build-args:GITHUB_TOKEN=${GITHUB_TOKEN} should be provided automatically by https://github.com/eclipse/che-theia/blob/3b9c9582ca1fdfd26a45230442f1db8bbed9c2fc/build.include#L79

@che-bot
Copy link
Contributor

che-bot commented Jul 8, 2020

❌ E2E Happy path tests failed ❗

Try Che-Theia editor only Try Che-Theia with Java/maven example Try Che-Theia with NodeJs example

See Details

name link
che-theia docker.io/maxura/che-theia:797
che-theia-endpoint-runtime-binary docker.io/maxura/che-theia-endpoint-runtime-binary:797

Tested with Eclipse Che Single User on K8S (minikube v1.1.1)

ℹ️ Use comment "crw-ci-test" to rerun happy path E2E test.

@benoitf
Copy link
Contributor

benoitf commented Mar 8, 2021

hello, is it still actual ?

vinokurig pushed a commit that referenced this pull request Apr 6, 2021
* Add support for building with buildah/podman/docker

Not all users have access to docker, so auto-detect whichever tool is available and working.

Part of eclipse-che/che#18798

Signed-off-by: Eric Williams <[email protected]>

* Fix README to better describe the new approaches

Signed-off-by: Eric Williams <[email protected]>

* Add bud as build command, if BUILDER=buildah

Signed-off-by: Eric Williams <[email protected]>

* Use BUILDER=docker in all CI jobs and devfile build

Signed-off-by: Eric Williams <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants