Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Imp] hide charts by default and toggle visibility based on user selection #2908

Merged
merged 1 commit into from
Aug 16, 2024

Conversation

aliseyalvi
Copy link
Collaborator

What does this PR?

  • removed chart from wallet screen
  • toggle chart visibility in assetDetailsScreen
  • added toggle animation

Issue number

https://discord.com/channels/@me/920267778190086205/1273221543874265098

Screenshots/Video

Monosnap.screencast.2024-08-15.19-56-33.mp4

* toggle chart visibility in assetDetailsScreen
* added toggle animation
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not very fond of the solution as a long term thing, however should be good for testing wallet crash.

@feruzm feruzm merged commit c4be9ec into development Aug 16, 2024
@feruzm feruzm deleted the sa/chart-fixes branch August 16, 2024 11:27
@feruzm
Copy link
Member

feruzm commented Aug 16, 2024

not very fond of the solution as a long term thing, however should be good for testing wallet crash.

@noumantahir yes let’s test if it helps and we can polish it further if it helps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants