Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated hook dependencies for better polls loading #2907

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

apparently on first time poll load, there is usually a gap between with the isLoading flag is updated and query data is available that was causing a permanent loading indicator on poll options.

@noumantahir noumantahir requested a review from feruzm August 6, 2024 11:45
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 407eefb into development Aug 7, 2024
@feruzm feruzm deleted the nt/polls-loading-fix branch August 7, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants