Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/build distribute fixes #2887

Merged
merged 2 commits into from
Jun 13, 2024
+9 −5
Merged

Nt/build distribute fixes #2887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e4d80af
removed duplicate package initialisation
noumantahir Jun 13, 2024
05c90b8
remove USE_FULL_SCREEN_INTENT removal from build
noumantahir Jun 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
<uses-permission android:name="android.permission.USE_BIOMETRIC" />
<uses-permission android:name="android.permission.USE_FINGERPRINT" />

<!--removes permission from build, fixes issue of notifee pushing permission in production -->
<uses-permission android:name="android.permission.USE_FULL_SCREEN_INTENT" tools:node="remove" />

<queries>
<intent>
<action android:name="android.intent.action.VIEW" />
Expand Down
11 changes: 6 additions & 5 deletions android/app/src/main/java/app/esteem/mobile/android/MainApplication.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,8 +32,6 @@

public class MainApplication extends MultiDexApplication implements ReactApplication {



private final ReactNativeHost mReactNativeHost = new ReactNativeHostWrapper(this, new DefaultReactNativeHost(this) {

@Override
Expand All @@ -49,10 +47,10 @@ protected List<ReactPackage> getPackages() {
// example:
// packages.add(new MyReactNativePackage());
packages.add(new PagerViewPackage());
packages.add(new UploaderReactPackage());
return packages;
}


@Override
protected String getJSMainModuleName() {
return "index";
Expand All @@ -62,6 +60,7 @@ protected String getJSMainModuleName() {
protected boolean isNewArchEnabled() {
return BuildConfig.IS_NEW_ARCHITECTURE_ENABLED;
}

@Override
protected Boolean isHermesEnabled() {
return BuildConfig.IS_HERMES_ENABLED;
Expand All @@ -88,10 +87,12 @@ public void onCreate() {
registerActivityLifecycleCallbacks(OrientationActivityLifecycle.getInstance());

if (BuildConfig.IS_NEW_ARCHITECTURE_ENABLED) {
// If you opted-in for the New Architecture, we load the native entry point for this app.
// If you opted-in for the New Architecture, we load the native entry point for
// this app.
DefaultNewArchitectureEntryPoint.load();
}
// ReactNativeFlipper.initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
// ReactNativeFlipper.initializeFlipper(this,
// getReactNativeHost().getReactInstanceManager());
ApplicationLifecycleDispatcher.onApplicationCreate(this);

}
Expand Down