Nt/multiple choice #2877
Merged
Nt/multiple choice #2877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
added support for POLL text/tag above title along with PROMOTED text 
|
|
UPDATE: refined poll choices styling a bit
BEFORE NOW |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
support for select multiple choices upto number mentioned in property
max_choices_votesright now, since out poll.ecency end point do not support updated schema, polls will not work as expected, for testing purposes I used poll-beta from hivehub
However, something to keep in mind, once we do update polls.ecency, our users using app variant that supports old version of polls will no longer be able to use polls as expected since updated schema returns array of
choicesinstead ofchoice_numunderpoll_votersUPDATE: merged poll blog icon branch into this, to show poll icon in user feed
Screenshots/Video
Screen.Recording.2024-05-22.at.18.53.20.mov
Screen.Recording.2024-05-22.at.18.41.12.mov
poll blog icon display
