Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep submit disabled for complete publishing routine #2871

Merged
merged 1 commit into from
May 15, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented May 15, 2024

What does this PR?

I was able to virtualise an environment that could lead to potential duplication of waves. Although it may or may not be source of post duplication.
Added redundancy to submit button in an effort to avoid such scenario. Let's put it to test and see if we still encounter more waves duplication or not

Issue number

ref: https://discord.com/channels/@me/920267778190086205/1240148539548500060

Screenshots/Video

result of bug recreation under virtualised environment.

Screenshot 2024-05-15 at 14 16 52

@noumantahir noumantahir requested a review from feruzm May 15, 2024 09:15
@feruzm feruzm merged commit 8229c54 into development May 15, 2024
@feruzm feruzm deleted the nt/duplicate-waves-fix branch May 15, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants