making sure announcement alert appear after welcome modal is closed #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR?
Apparently on new update/install, announcement modal was appearing on top of welcome modal, which not only felt annoyed, it might have also caused us to lose possible votes during our last rollout, because at this stage app was not ready to process vote and we might have ended up losing it.
What I also suggest is, after some time of rolling out new update should create a new announcement with different ID and content to encourage users to vote again.
To make it less annoying we can even chose to check if target user already voted, let me know.
Screenshots/Video
BEFORE
NOW
Screen.Recording.2024-04-29.at.17.22.15.mov