[Improve] profile edit screen #2857
Conversation
* fixed a bug while updating cover image
| ({ username, name, reputation, avatarUrl, showImageUploadActions, isUploading }) => | ||
| () => { | ||
| const navigation = useNavigation(); | ||
| const AvatarHeader = ({ |
There was a problem hiding this comment.
if AvatarHeader is not being used anywhere else perhaps we can rename component to EditAvatar
There was a problem hiding this comment.
edit functionality working great... left some comment and some feedback below as well...
-
After updating cover photo, the cover image still remains locked to older cover in profile details screen. even tried restarting. avatar image instead updated instantly.
-
when user updates either profile picture or cover photo, perhaps we should skip the need to tap SAVE button, it should update data automatically, only textual update may require tapping save button after wards.
-
can we try enabling cropping for cover picture as well, or perhaps we left it out on purpose for some reason. may be different platform process cover photo differently, need more digging
| avatarUrl={avatarUrl} | ||
| isLoading={isUploading} | ||
| /> | ||
| <IconButton |
There was a problem hiding this comment.
Button background should primary blue, and perhaps use pencil icon instead plus/add, can also be slightly bigger may be.
| }; | ||
| <View style={styles.textWrapper}> | ||
| {!!name && <Text style={styles.name}>{name}</Text>} | ||
| <Text style={styles.username}>{`@${username} (${reputation})`}</Text> |
There was a problem hiding this comment.
this does not make sense here... perhaps we can use similar header as used in profile screen without display name and reputation...
| <UserAvatar | ||
| key={`${avatarUrl}-${username}`} | ||
| noAction | ||
| size="xl" |
There was a problem hiding this comment.
try using even larger size is possible without making alot of changes
* removed username and reputation
aliseyalvi
changed the title
|
@aliseyalvi two things
|
* show loader on edit icon instead of img * increased size of edit icon
What does this PR?
Issue number
https://discord.com/channels/@me/920267778190086205/1229321662663495720
Screenshots/Video
Screenrecorder-2024-04-16-17-19-23-707.mp4