Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nt/expo #2848

Merged
merged 4 commits into from
Mar 6, 2024
Merged

Nt/expo #2848

merged 4 commits into from
Mar 6, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Mar 6, 2024

What does this PR?

basic expo integration

at this stage it does not directly impact anything in app but makes the app capable of supporting expo managed packages moving forward.

purpose of this PR is to start testing app for any instabilities that expo might have caused as my first attempt of integration few days back disturbed the redux persistence for some reason, had to revert all and do again every integration manually.

Initially testing suggests app is stable, but we should build and let testers use app to check stability. meanwhile will integration expo-image, the primary package for which we initially started all the up gradation process.

@noumantahir noumantahir requested a review from feruzm March 6, 2024 12:33
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 74f29d0 into development Mar 6, 2024
@feruzm feruzm deleted the nt/expo branch March 6, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants