Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support to process hiveuris from notification data #2825

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Feb 3, 2024

What does this PR?

This code is written in a way spend as little time refactoring code to support hive uri processing directly from notification, we can refactor things once we resume development properly with good funds. I have placed a TODO in code to keep us reminded of that

To make it work...

With notification package add the following data...

type:"hiveuri"
hiveUri:"hive://sign/op/....."

and app should be to decode uri and present appropriate action to be performed

Screenshots/Video

Screenshot 2024-02-03 235105

@noumantahir noumantahir requested a review from feruzm February 3, 2024 19:01
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets do some tests.

@feruzm feruzm merged commit 8a33ab8 into development Feb 4, 2024
@feruzm feruzm deleted the nt/hiveuri-notifications branch February 4, 2024 05:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants