Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/comment modal #2797

Merged
merged 11 commits into from
Dec 12, 2023
Merged

Nt/comment modal #2797

merged 11 commits into from
Dec 12, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

  • migrated all actions sheets to version 8
  • replaced custom reply modal with updated actions sheet
  • no longer directly updated reply input value using state

Issue number

https://github.com/orgs/ecency/projects/2#card-83050792

Screenshots/Video

Screenshot 2023-12-12 at 15 34 53 Screenshot 2023-12-12 at 15 35 06

@noumantahir noumantahir requested a review from feruzm December 12, 2023 10:37
@noumantahir noumantahir marked this pull request as ready for review December 12, 2023 10:37
feruzm
feruzm approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 9b1f1d6 into development Dec 12, 2023
@feruzm feruzm deleted the nt/comment-modal branch December 12, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm