Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

injecting image urls and ratios in comment metadata #2780

Merged
merged 1 commit into from
Oct 17, 2023

Conversation

noumantahir
Copy link
Collaborator

What does this PR?

Injecting image url was already supported for comment using quick reply modal, now added similar support for main editor comments as well

Screenshots/Video

Main editor comment metadata
Screenshot 2023-10-17 at 5 25 50 PM

Quick reply modal metadata
Screenshot 2023-10-17 at 5 20 04 PM

data retention on update
Screenshot 2023-10-17 at 5 26 24 PM

@noumantahir noumantahir requested a review from feruzm October 17, 2023 12:30
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@feruzm feruzm merged commit 366e227 into development Oct 17, 2023
@feruzm feruzm deleted the nt/comment-meta-update branch October 17, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants