Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 2746 add recurrent transfer feature for hive #2764

Merged
merged 8 commits into from
Nov 1, 2023
Merged

feat: 2746 add recurrent transfer feature for hive #2764

merged 8 commits into from
Nov 1, 2023

Conversation

gamingumar
Copy link
Collaborator

@gamingumar gamingumar commented Sep 26, 2023 •
edited
Loading

What does this PR?

Add Recurrent Transfer Feature for Hive

Issue number 2746

Video

recurrent.transfer.mp4

Screenshots

recurrent-2

recurrent-1

@gamingumar gamingumar changed the title feat: 2746 add recurrent transfer option in UI, api call added feat: #2746 add recurrent transfer option in UI, api call added Sep 26, 2023
@gamingumar gamingumar changed the title feat: #2746 add recurrent transfer option in UI, api call added feat: 2746 add recurrent transfer option in UI, api call added Sep 26, 2023
@gamingumar gamingumar mentioned this pull request Sep 26, 2023
Open
@gamingumar gamingumar self-assigned this Sep 26, 2023
@gamingumar gamingumar marked this pull request as draft September 26, 2023 17:46
@feruzm
Copy link
Member

feruzm commented Sep 26, 2023

@gamingumar recurrence is in hours, I think, so UI should indicate that, so person knows for sure.

@noumantahir
Copy link
Collaborator

Direction is good, let's hope we do not have add more props to components, please check the comments above....

@gamingumar gamingumar changed the base branch from development to master October 25, 2023 10:04
@gamingumar gamingumar changed the base branch from master to development October 25, 2023 10:04
@gamingumar gamingumar force-pushed the feat/GU-2746/recurrent-transfer branch from ce75df5 to 6d69b42 Compare October 25, 2023 10:06
@gamingumar gamingumar force-pushed the feat/GU-2746/recurrent-transfer branch from 6d69b42 to 2366b1e Compare October 25, 2023 10:10
@gamingumar gamingumar marked this pull request as ready for review October 27, 2023 17:34
@gamingumar gamingumar changed the title feat: 2746 add recurrent transfer option in UI, api call added feat: 2746 add recurrent transfer feature for hive Oct 27, 2023
noumantahir
noumantahir approved these changes Oct 30, 2023
View reviewed changes
Copy link
Collaborator

@noumantahir noumantahir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good functionality wise, need more testing before we can merge... source is growing out of hands overall, will have to sit and plan for transfers/wallet actions rewiring soon, otherwise it will become chaos to manage.

@noumantahir
Copy link
Collaborator

noumantahir commented Nov 1, 2023 •
edited
Loading

@feruzm should be good for now... removing recurring transfers can improve as we integrate list of subscription in asset details screen.

Screenshot 2023-11-01 at 20 44 25

@feruzm feruzm merged commit 6e7d13d into development Nov 1, 2023
@feruzm feruzm deleted the feat/GU-2746/recurrent-transfer branch November 1, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm left review comments

@noumantahir noumantahir noumantahir approved these changes

Assignees

@gamingumar gamingumar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gamingumar @feruzm @noumantahir