Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nt/wave post data #2761

Merged
merged 5 commits into from
Sep 25, 2023
Merged

Nt/wave post data #2761

merged 5 commits into from
Sep 25, 2023

Conversation

noumantahir
Copy link
Collaborator

@noumantahir noumantahir commented Sep 22, 2023 •
edited
Loading

What does this PR?

  • changes prefix for comment and wave type posts
  • update json_metadata with type of post....

values taken from PostTypes enum in constants...

export enum PostTypes {
  POST = 'post',
  COMMENT = 'comment',
  WAVE = 'wave'
}

Issue number

https://discord.com/channels/@me/920267778190086205/1154694423167389718

Screenshots/Video

Screenshot 2023-09-22 at 6 04 14 PM
Screenshot 2023-09-22 at 6 03 14 PM

@noumantahir noumantahir requested a review from feruzm September 22, 2023 13:10
@noumantahir
Merge branch 'development' into nt/wave-post-data
18da9d2 
# Conflicts:
#	src/components/quickReplyModal/usePostSubmitter.ts
#	src/utils/editor.ts
@noumantahir
missing PostTypes fix
494018c
@noumantahir noumantahir changed the title Nt/wave post data [WIP] Nt/wave post data Sep 25, 2023
@noumantahir noumantahir changed the title [WIP] Nt/wave post data Nt/wave post data Sep 25, 2023
feruzm
feruzm approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@feruzm feruzm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@feruzm feruzm merged commit 369fe36 into development Sep 25, 2023
@feruzm feruzm deleted the nt/wave-post-data branch September 25, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@feruzm feruzm feruzm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@noumantahir @feruzm