Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'dubious ownership' when installing prometheus exporter #368

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

moonlies
Copy link
Contributor

When installing the prometheus monitoring exporter, the role fails when running the playbook for the second time, because the bbb-exporter's home directory, the cloned repository, is owned by the bbb-exporter user, who could modify the contents which could lead to privilege escalation. So ansible stops the playbook at that point. Retaining ownership with the root user keeps bbb-exporter from potentially being able to modify anything and the role finishes successfully.

This problem occurs when running with bbb_monitoring_external: true

@BrutalBirdie
Copy link
Collaborator

BrutalBirdie commented Nov 20, 2023

Odd, I always use bbb_monitoring_external but it never crashed on my on a re-run.
I will check this out.

Thanks for the PR and work ❤️

@BrutalBirdie BrutalBirdie added the enhancement New feature or request label Nov 21, 2023
@BrutalBirdie
Copy link
Collaborator

Now I know why this never occurred to me.
I always use the bbb_monitoring_all_in_one_directory option which then installs it in /root/bbb-monitoring and runs in docker.

Will test again.

@BrutalBirdie BrutalBirdie requested a review from Davka November 27, 2023 11:07
@BrutalBirdie BrutalBirdie merged commit 3a587a3 into ebbba-org:master Nov 30, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants