-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies to tracing-subscriber 0.3 #12
Conversation
This is necessary for compatibility with `trait Layer<S>` in tracing-subscriber v0.3.3.
Update dependency to tracing_subscriber 0.3
The last CI-run failed due to an internal compiler error in nightly as described in rust-lang/rust#91663. They recommend running Therefore I'm not changing this PR and ask for a rerun of the pipeline sometime. |
@jfhbrook-at-work you're taking this one right? |
Good point! Definitely for tracing-distributed; does tracing-honeycomb's patch number need +1 too? |
@ericsampson Yeah, I'm gonna try to look at this in the next few days! |
I'd think so. Does this change have any effect on the public API surface or behavior for consumers of tracing-honeycomb? |
The public API of tracing honeycomb is not influenced from what I understand. The only change I had to make, in order to make tracing-distributed compatible with the current version of tracing-subscriber, is to rename the Nice to hear you'll be maintaining this cool project^^. From my experience of using tracing-distributed directly so far I'll have some more remarks/questions in the near future. |
Sounds great!!! |
I ran into a problem when using the current version of tracing-appender with a custom telemetry layer built on tracing-distributed since they renamed the associated function
new_span
.Tests for both crates with default config pass with this update, but I'm not a user of honeycomb, so I have not tested further than that.
Feedback is appreciated.