[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 #775

khoih-prog · 2022-08-20T04:00:47Z

As you've done so great work for lwIP_CYW43, lwIP_Ethenet and cyw43 WiFi libraries, could you please, when having time, port these libraries :

from ESP826 to this powerful and popular core.

Those LwIP-based libraries would be used in newly-created Async-related libraries, similar to those for RP2040W, as in Libraries created / updated to support RASPBERRY_PI_PICO_W using CYW43439 WiFi #757

earlephilhower · 2022-08-20T17:34:59Z

I have an ENC28 and a W5500S(thanks, WizNet!), but not the other two. Do you have a W5100 or W5500 to test on? It's in the queue, but only so many hours in the day.

When they get ported everything WiFi can do, they will be able to do (i.e. SSL connections, UDP, servers, NTP, etc.). You'll still need to use a WiFiClient or WiFiServer object, but they are really LWIPClientand LWIPServer under the hood and have no WiFi constraints (or at least, they shouldn't!)

khoih-prog · 2022-08-20T18:21:20Z

Good news the tasks are in the queue.

It's in the queue, but only so many hours in the day.

Totally understand. I get the same constraint, even if I'd like to help port them.

I have W5100 and W5500 to test.

BTW, is that possible to add DNSServer library or code into the core or WiFi lib ?

I'm trying to port DNSServer library, but having some issue with UDP packet receiving.

Everything will be done much faster by you, as previous maintainer of ESP8266 core.

earlephilhower · 2022-08-20T19:03:03Z

@khoih-prog Try #779. DNSServer just built fine with trivial fixes (WDT reset ignore, remove obsolete BIT() macro).

khoih-prog · 2022-08-20T19:23:13Z

Thanks for the DNSServer.

Still have the same issue in WiFiUDP::parsePacket() : _ctx->next is always NULL.
Some missing config in LwIP stack relating to DNSServer ??

arduino-pico/libraries/WiFi/src/WiFiUdp.cpp

Lines 182 to 184 in 7be4729

    
           if (!_ctx->next()) { 
        
               return 0; 
        
           }

Test code

#define USE_WIFI_NINA         false
#define USE_WIFI101           false
#define USE_WIFI_CUSTOM       false

#include <WiFi.h>
#include <DNSServer.h>
#include <WiFiWebServer.h>

const byte DNS_PORT = 53;
IPAddress apIP(192, 168, 42, 1);

DNSServer dnsServer;
WiFiWebServer webServer(80);

String responseHTML = ""
                      "<!DOCTYPE html><html lang='en'><head>"
                      "<meta name='viewport' content='width=device-width'>"
                      "<title>CaptivePortal</title></head><body>"
                      "<h1>Hello World!</h1><p>This is a captive portal example."
                      " All requests will be redirected here.</p></body></html>";

void setup()
{
  // Debug console
  Serial.begin(115200);
  while (!Serial && millis() < 5000);

  delay(1000);

  Serial.print("\nStart CaptivePortal on "); Serial.println(BOARD_NAME);
  
  WiFi.mode(WIFI_AP);

  WiFi.beginAP("DNSServer CaptivePortal example");

  // if DNSServer is started with "*" for domain name, it will reply with
  // provided IP to all DNS request
  bool dnsServer_OK = false;
  
  dnsServer_OK = dnsServer.start(DNS_PORT, "*", apIP);

  if (dnsServer_OK)
    Serial.println("dnsServer starting OK");
  else
    Serial.println("dnsServer starting failure");  

  // replay to all requests with same HTML
  webServer.onNotFound([]()
  {
    webServer.send(200, "text/html", responseHTML);
  });

  webServer.begin();
}

void loop()
{
  dnsServer.processNextRequest();
  webServer.handleClient();
}

khoih-prog · 2022-08-20T19:27:26Z

Strange, WiFiUDP::parsePacket() is OK when I'm running UdpNTPClient

No more problem with _ctx->next is always NULL.

arduino-pico/libraries/WiFi/src/WiFiUdp.cpp

Lines 182 to 184 in 7be4729

    
           if (!_ctx->next()) { 
        
               return 0; 
        
           }

earlephilhower · 2022-08-20T20:37:38Z

Yeah, I just went back and checked the WiFiUDP example to make sure things were good.

At this point I think it may be "routing" related since the UDP code doesn't know or care if in AP or STA mode. This looks to take some digging.

An easy verification would to make the WiFiUDP example run over an AP not STA and verify failure. Plus that would be a simpler test on a known good code block for any fix (i.e. I did not dig into the DNS server guts so maybe there are 8266-specific assumptions somewhere).

earlephilhower · 2022-08-20T21:40:34Z

Thinking out loud, LWIP UDP while in AP mode can't be completely borked. The DHCP server does give addresses out therefore it is able to receive and send UDP packets. So something in this core is looking at a received UDP packet and saying, "nope...not for me."

earlephilhower · 2022-08-20T22:36:36Z

@khoih-prog well, that was obvious. DHCP server gave 8.8.8.8 hardcoded as DNS server, not the GW IP. Check the latest DNSServer PR for the update. I now see DNS requests being processed by the AP.

khoih-prog · 2022-08-20T23:34:52Z

@earlephilhower

Wow. Amazingly quick and the bug is fixed.

Now Captive Portal for DNSServer is working now when entering any non-existing site, such as example.ca.

Would you like me to make a PR for the examples for DNSServer

Captive Portal Code used for the test

#define USE_WIFI_NINA         false
#define USE_WIFI101           false
#define USE_WIFI_CUSTOM       false

#include <WiFi.h>
#include <DNSServer.h>
#include <WiFiWebServer.h>

const byte DNS_PORT = 53;
IPAddress apIP(192, 168, 42, 1);

DNSServer dnsServer;
WiFiWebServer webServer(80);

String responseHTML = ""
                      "<!DOCTYPE html><html lang='en'><head>"
                      "<meta name='viewport' content='width=device-width'>"
                      "<title>CaptivePortal</title></head><body>"
                      "<h1>Hello World!</h1><p>This is a captive portal example."
                      " All requests will be redirected here.</p></body></html>";

void setup()
{
  // Debug console
  Serial.begin(115200);
  while (!Serial && millis() < 5000);

  delay(1000);

  Serial.print("\nStart CaptivePortal on "); Serial.println(BOARD_NAME);
  
  WiFi.mode(WIFI_AP);

  WiFi.beginAP("DNSServer CaptivePortal example");

  // if DNSServer is started with "*" for domain name, it will reply with
  // provided IP to all DNS request
 if (dnsServer.start(DNS_PORT, "*", apIP))
    Serial.println("dnsServer starting OK");
  else
    Serial.println("dnsServer starting failure");

  // replay to all requests with same HTML
  webServer.onNotFound([]()
  {
    webServer.send(200, "text/html", responseHTML);
  });

  webServer.begin();
}

void loop()
{
  dnsServer.processNextRequest();
  webServer.handleClient();
}

khoih-prog · 2022-08-21T01:20:09Z

@earlephilhower

Is that possible to add WebServer library, similar to ESP8266WebServer into the core ?

It's required for certain WebServer apps, with simpler way to use, such as

server.on("/", handleRoot);

I can help if you'd like.

earlephilhower · 2022-08-21T02:08:42Z

It's in the queue. First I'm looking into HTTPClient (and want to fix the odd requirements we have on the 8266/32 which catch folks by surprise) then the web server. Lots of stuff in this here queue. :)

khoih-prog · 2022-08-21T02:10:15Z

Wow. Glad to know.

Ing-Dom · 2023-02-04T12:43:09Z

I'm interested in this.
Is it possible atm to use w5500 together with this core and the core's lwip ?

WIP - Builds and can get a DHCP address using W5500. Lots of infrastructure work still required: [ ] Separate CYW43 stuff and LWIP stuff (mutex, etc.) [ ] Add async worker for pumping frames [ ] Real LWIP-only mutex [ ] Should WiFiClient be available as TCPClient? etc. Fixes #775

Enable use of wired Ethernet modules as first-class LWIP citizens. All networking classes like MDNS, WebServer, HTTPClient, WiFiClient, and OTA can use a wired Ethernet adapter just like built-in WiFi. Two examples updated to show proper use. Uses the Async Context support built into the Pico SDK. When running on the Pico it will use the CYW43 async instance. Uses modified wired Ethernet drivers, thanks Nicholas Humfrey! Note, the classic, non-LWIP integrated `Ethernet` and related libraries should still work fine (but not be able to use WebServer/HTTPS/etc.) Fixes #775

earlephilhower added the enhancement New feature or request label Aug 20, 2022

khoih-prog changed the title ~~[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP826~~ [Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60, DNSServer, ESP8266WebServer from ESP826 Aug 21, 2022

khoih-prog changed the title ~~[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60, DNSServer, ESP8266WebServer from ESP826~~ [Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60, DNSServer, ESP8266WebServer from ESP8266 Aug 21, 2022

earlephilhower changed the title ~~[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60, DNSServer, ESP8266WebServer from ESP8266~~ [Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 Aug 25, 2022

maxgerhardt mentioned this issue Apr 27, 2023

HttpClient hardlocks on GET-Request #1403

Closed

earlephilhower mentioned this issue May 31, 2023

Ethernet on w5100s-evb-pico #1489

Closed

earlephilhower mentioned this issue Sep 9, 2023

Support wired network interfaces (W5500, W5100, ENC28J60) #1703

Merged

earlephilhower closed this as completed in #1703 Sep 15, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 #775

[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 #775

khoih-prog commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

khoih-prog commented Aug 20, 2022

earlephilhower commented Aug 20, 2022 •

edited

Loading

khoih-prog commented Aug 20, 2022

khoih-prog commented Aug 20, 2022 •

edited

Loading

earlephilhower commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

khoih-prog commented Aug 20, 2022 •

edited

Loading

khoih-prog commented Aug 21, 2022

earlephilhower commented Aug 21, 2022

khoih-prog commented Aug 21, 2022

Ing-Dom commented Feb 4, 2023

[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 #775

[Feature Request] Port these libraries lwIP_w5100, lwIP_w5500 and lwIP_enc28j60 from ESP8266 #775

Comments

khoih-prog commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

khoih-prog commented Aug 20, 2022

earlephilhower commented Aug 20, 2022 • edited Loading

khoih-prog commented Aug 20, 2022

Test code

khoih-prog commented Aug 20, 2022 • edited Loading

earlephilhower commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

earlephilhower commented Aug 20, 2022

khoih-prog commented Aug 20, 2022 • edited Loading

Captive Portal Code used for the test

khoih-prog commented Aug 21, 2022

earlephilhower commented Aug 21, 2022

khoih-prog commented Aug 21, 2022

Ing-Dom commented Feb 4, 2023

earlephilhower commented Aug 20, 2022 •

edited

Loading

khoih-prog commented Aug 20, 2022 •

edited

Loading

khoih-prog commented Aug 20, 2022 •

edited

Loading