Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Fast CDR version in .repos files #187

Merged
merged 1 commit into from
Oct 17, 2024
Merged

Fix Fast CDR version in .repos files #187

merged 1 commit into from
Oct 17, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Oct 17, 2024 •
edited
Loading

Description

The Fast DDS v3.1.0 release required the Fast CDR v2.2.5 version for compatibility.
This PR updates the .repos file for ShapesDemo corresponding 3.1.x branch to use also Fast CDR v2.2.5 version.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A Changes do not break current interoperability.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@JesusPoderoso JesusPoderoso added this to the v3.1.1 milestone Oct 17, 2024
@JesusPoderoso JesusPoderoso self-assigned this Oct 17, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 17, 2024
Mario-DL
Mario-DL approved these changes Oct 17, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Oct 17, 2024
@JesusPoderoso JesusPoderoso merged commit 6693b5f into 3.1.x Oct 17, 2024
4 checks passed
@JesusPoderoso JesusPoderoso deleted the hotfix/fastcdr branch October 17, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees

@JesusPoderoso JesusPoderoso

Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.1.1 - Frozen ❄️
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @Mario-DL