Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20709] Substitute CDRMessage private function with a simple operation #136

Merged
merged 1 commit into from
May 24, 2024
Merged

[20709] Substitute CDRMessage private function with a simple operation #136

merged 1 commit into from
May 24, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented May 22, 2024 •
edited by JesusPoderoso
Loading

Description

The related implementation PR eProsima/Fast-DDS#4657 makes CDRMessage.h private.
This PR substitutes a CDRMessage private function with a simple operation since it was not strictly necessary to use it.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • Changes do not break current interoperability.
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • CI passes without warnings or errors.

@elianalf elianalf added this to the v3.0.0 milestone May 22, 2024
@elianalf elianalf mentioned this pull request May 22, 2024
Merged
7 tasks
JesusPoderoso
JesusPoderoso approved these changes May 23, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit c72e0f2 into master May 24, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/make_private_rtps_messages branch May 24, 2024 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

@EduPonz EduPonz EduPonz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@elianalf @EduPonz @JesusPoderoso