Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20176] Regenerate Fast DDS docs example types due to Gen release v3.2.1 #103

Merged
merged 1 commit into from
Jan 11, 2024
Merged

[20176] Regenerate Fast DDS docs example types due to Gen release v3.2.1 #103

merged 1 commit into from
Jan 11, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jan 10, 2024 •
edited
Loading

This PR regenerates the Shape types.
This is needed to introduce the Fast DDS Gen release v3.2.1 changes.

Mario-DL
Mario-DL requested changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When regenerating the Shape.idl, specify the -cdr both argument and update.

@JesusPoderoso JesusPoderoso force-pushed the feature/regenerate_types_genv3.2.1 branch from e1d3031 to ef02ba1 Compare January 11, 2024 09:28
@JesusPoderoso JesusPoderoso reopened this Jan 11, 2024
Mario-DL
Mario-DL approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso merged commit 5ee66a9 into master Jan 11, 2024
10 checks passed
@JesusPoderoso JesusPoderoso deleted the feature/regenerate_types_genv3.2.1 branch January 11, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mario-DL Mario-DL Mario-DL approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JesusPoderoso @Mario-DL