Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing #5480

Merged
merged 6 commits into from
Dec 13, 2024
Merged

[21660] Add flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing #5480

merged 6 commits into from
Dec 13, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Dec 10, 2024 •
edited by rsanchez15
Loading

Description

This PR adds the flow_control, rtps, custom_payload_pool and content_filter to windows example ci testing.
In particular, it

  • Adds the required infrastructure to include environment args splitting them to be recognized as different argv in windows.
  • Includes a new matched argument to the rtps example to wait for discovery before publishing.
  • Adds a new argument samples to the subscriber content filter as a finish condition when it gets unmatched.

Note: In the content filter example the PUB_ARGS was removed since it was not being used in the compose file.

@Mergifyio backport 3.1.x 3.0.x

Contributor Checklist

  • [X ] Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.2.0 milestone Dec 10, 2024
@Mario-DL Mario-DL requested review from richiprosima and removed request for richiprosima December 10, 2024 16:05
@github-actions github-actions bot added the ci-pending PR which CI is running label Dec 10, 2024
@rsanchez15 rsanchez15 merged commit 0deeb14 into master Dec 13, 2024
17 checks passed
@rsanchez15 rsanchez15 deleted the examples/21660 branch December 13, 2024 08:19
@Mario-DL
Copy link
Member Author

@Mergifyio backport 3.1.x 3.0.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 13, 2024 •
edited
Loading

backport 3.1.x 3.0.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@Mario-DL @mergify
Add flow_control, rtps, custom_payload_pool and `content_filter…
a20f4b9 
…` to windows example ci testing (#5480)

* Refs #21660: Flow controller example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: RTPS example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Custom PayloadPool example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Additional cmake vars for configuring extra arguments lists

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Content Filter example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Add examples to CMakeLists.txt

Signed-off-by: Mario-DL <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
(cherry picked from commit 0deeb14)

# Conflicts:
#	test/examples/CMakeLists.txt
#	test/examples/content_filter.compose.yml
#	test/examples/custom_payload_pool.compose.yml
#	test/examples/rtps.compose.yml
mergify bot pushed a commit that referenced this pull request Dec 13, 2024
@Mario-DL @mergify
Add flow_control, rtps, custom_payload_pool and `content_filter…
3896769 
…` to windows example ci testing (#5480)

* Refs #21660: Flow controller example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: RTPS example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Custom PayloadPool example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Additional cmake vars for configuring extra arguments lists

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Content Filter example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Add examples to CMakeLists.txt

Signed-off-by: Mario-DL <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
(cherry picked from commit 0deeb14)

# Conflicts:
#	test/examples/CMakeLists.txt
#	test/examples/content_filter.compose.yml
#	test/examples/custom_payload_pool.compose.yml
#	test/examples/rtps.compose.yml
This was referenced Dec 13, 2024
Merged
Open
Mario-DL added a commit that referenced this pull request Dec 16, 2024
@Mario-DL
Add flow_control, rtps, custom_payload_pool and `content_filter…
e561c43 
…` to windows example ci testing (#5480)

* Refs #21660: Flow controller example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: RTPS example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Custom PayloadPool example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Additional cmake vars for configuring extra arguments lists

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Content Filter example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Add examples to CMakeLists.txt

Signed-off-by: Mario-DL <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Dec 17, 2024
@mergify @Mario-DL
Add flow_control, rtps, custom_payload_pool and `content_filter…
56f9a3c 
…` to windows example ci testing (#5480) (#5490)

* Refs #21660: Flow controller example



* Refs #21660: RTPS example



* Refs #21660: Custom PayloadPool example



* Refs #21660: Additional cmake vars for configuring extra arguments lists



* Refs #21660: Content Filter example



* Refs #21660: Add examples to CMakeLists.txt



---------

Signed-off-by: Mario-DL <[email protected]>
Co-authored-by: Mario Domínguez López <[email protected]>
Mario-DL added a commit that referenced this pull request Jan 10, 2025
@Mario-DL
Add flow_control, rtps, custom_payload_pool and `content_filter…
7ff4f93 
…` to windows example ci testing (#5480)

* Refs #21660: Flow controller example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: RTPS example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Custom PayloadPool example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Additional cmake vars for configuring extra arguments lists

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Content Filter example

Signed-off-by: Mario-DL <[email protected]>

* Refs #21660: Add examples to CMakeLists.txt

Signed-off-by: Mario-DL <[email protected]>

---------

Signed-off-by: Mario-DL <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rsanchez15 rsanchez15 rsanchez15 approved these changes

Assignees
No one assigned
Labels
ci-pending PR which CI is running
Projects
None yet
Milestone
v3.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Mario-DL @rsanchez15