-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21745] Fix flow_controllers comparison in DomainParticipantQos equality operator #5295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Failed test unrelated
Im fine with leaving the comparator as a method in DomainParticipantQoS
.
Please, add a commit adding the new DomainparticipantQoS.compare_flow_controllers
to the versions.md
…ter address Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
Signed-off-by: Juan Lopez Fernandez <[email protected]>
8a3fd08
to
bca7e37
Compare
Signed-off-by: Juan Lopez Fernandez <[email protected]>
bca7e37
to
4425b85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Description
DomainParticipantQos objects contain an attribute of kind
FlowControllerDescriptorList
, which is a vector ofFlowControllerDescriptor
shared pointers. Currently the comparison of two equivalent DomainParticipantQos objects is failing when the elements in this list are not the same (determined by memory address) instead of dereferencing and performing the comparison element-wise. This PR fixes this behaviour.Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist