Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21745] Fix flow_controllers comparison in DomainParticipantQos equality operator #5295

Merged
merged 4 commits into from
Oct 7, 2024

Conversation

juanlofer-eprosima
Copy link
Contributor

@juanlofer-eprosima juanlofer-eprosima commented Oct 3, 2024

Description

DomainParticipantQos objects contain an attribute of kind FlowControllerDescriptorList, which is a vector of FlowControllerDescriptor shared pointers. Currently the comparison of two equivalent DomainParticipantQos objects is failing when the elements in this list are not the same (determined by memory address) instead of dereferencing and performing the comparison element-wise. This PR fixes this behaviour.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@juanlofer-eprosima juanlofer-eprosima changed the title Fix flow_controllers comparison in DomainParticipantQos equality operator [21745] Fix flow_controllers comparison in DomainParticipantQos equality operator Oct 3, 2024
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 3, 2024 07:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 3, 2024
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 3, 2024 08:34
@JesusPoderoso JesusPoderoso added this to the v3.1.0 - Frozen ❄️ milestone Oct 4, 2024
@Mario-DL Mario-DL removed the ci-pending PR which CI is running label Oct 4, 2024
Mario-DL
Mario-DL previously approved these changes Oct 4, 2024
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Failed test unrelated
Im fine with leaving the comparator as a method in DomainParticipantQoS .
Please, add a commit adding the new DomainparticipantQoS.compare_flow_controllers to the versions.md

@Mario-DL Mario-DL added versions-pending skip-ci Automatically pass CI labels Oct 4, 2024
@juanlofer-eprosima juanlofer-eprosima force-pushed the bugfix/qos-compare-flowcontrollers branch from 8a3fd08 to bca7e37 Compare October 4, 2024 07:03
@Mario-DL Mario-DL removed skip-ci Automatically pass CI versions-pending labels Oct 4, 2024
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 4, 2024 07:06
@github-actions github-actions bot added the ci-pending PR which CI is running label Oct 4, 2024
Signed-off-by: Juan Lopez Fernandez <[email protected]>
@juanlofer-eprosima juanlofer-eprosima force-pushed the bugfix/qos-compare-flowcontrollers branch from bca7e37 to 4425b85 Compare October 4, 2024 07:10
@juanlofer-eprosima juanlofer-eprosima requested review from richiprosima and removed request for richiprosima October 4, 2024 07:10
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@juanlofer-eprosima juanlofer-eprosima merged commit 59590c0 into master Oct 7, 2024
17 checks passed
@juanlofer-eprosima juanlofer-eprosima deleted the bugfix/qos-compare-flowcontrollers branch October 7, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants