Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix: Fix rtps example installation path #5113

Merged
merged 1 commit into from
Jul 29, 2024
Merged

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jul 29, 2024

Description

This PR fixes the installation path of the rtps example in the cmake file adding a missing "$".

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jul 29, 2024
@elianalf elianalf added the no-test Skip CI tests if PR marked with this label label Jul 29, 2024
@elianalf elianalf requested a review from EduPonz July 29, 2024 09:45
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 29, 2024
@elianalf elianalf changed the title Hofix: Fix rtps example installation path Hotfix: Fix rtps example installation path Jul 29, 2024
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 29, 2024
@EduPonz EduPonz removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels Jul 29, 2024
@EduPonz EduPonz merged commit 8e38577 into master Jul 29, 2024
14 checks passed
@EduPonz EduPonz deleted the update_example_path branch July 29, 2024 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants