Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21420] Fix wait argument in configuration example #5106

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

depink5
Copy link
Contributor

@depink5 depink5 commented Jul 26, 2024

Description

Fixed wait bug in configuration example. By default, Publisher was waiting for one Subscriber to start publishing. Changed the condition to 0.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 26, 2024
@rsanchez15 rsanchez15 changed the title Fix wait argument in configuration example [21420] Fix wait argument in configuration example Jul 26, 2024
@rsanchez15 rsanchez15 added this to the v3.0.0 milestone Jul 26, 2024
@depink5 depink5 force-pushed the hotfix/configuration_example branch from 7da4d7a to 0f2d011 Compare July 26, 2024 09:07
@rsanchez15 rsanchez15 requested review from Carlosespicur and removed request for Mario-DL and JesusPoderoso July 26, 2024 09:36
@rsanchez15 rsanchez15 merged commit bb3a056 into master Jul 29, 2024
16 of 17 checks passed
@rsanchez15 rsanchez15 deleted the hotfix/configuration_example branch July 29, 2024 05:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants