Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21226] Update types regeneration script homing path #5093

Merged
merged 1 commit into from
Jul 22, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 22, 2024

Description

This PR updates the type regeneration utils script to request itself to be launched from project root directory, instead of from the utils script folder. This is needed to standardize the Fast DDS Gen CI.
Related PR:

(tested locally)

Contributor Checklist

  • Commit messages follow the project guidelines.
  • N/A The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • N/A Check CI results: changes do not issue any warning.
  • N/A Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added the skip-ci Automatically pass CI label Jul 22, 2024
@JesusPoderoso JesusPoderoso added this to the v2.10.5 milestone Jul 22, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 22, 2024
@JesusPoderoso JesusPoderoso added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 22, 2024
@MiguelCompany MiguelCompany merged commit 47cb38c into 2.10.x Jul 22, 2024
14 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/21226 branch July 22, 2024 06:51
@JesusPoderoso
Copy link
Contributor Author

@Mergifyio backport 2.6.x

Copy link
Contributor

mergify bot commented Jul 26, 2024

backport 2.6.x

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 26, 2024
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 47cb38c)

# Conflicts:
#	utils/scripts/update_generated_code_from_idl.sh
juanlofer-eprosima pushed a commit that referenced this pull request Sep 2, 2024
Signed-off-by: JesusPoderoso <[email protected]>
(cherry picked from commit 47cb38c)

# Conflicts:
#	utils/scripts/update_generated_code_from_idl.sh

Co-authored-by: Jesús Poderoso <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants