Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21387] Fix build issues and update CI infrastructure to detect them #5083

Merged
merged 8 commits into from
Jul 23, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 18, 2024

Description

Due to an infrastructure issue with an internal action for Windows, the CI was not properly applying some CMake arguments while testing Fast DDS on Windows. Among others, the examples were not built, so CI passed even though.

This PR fixes the build issue, and tests the changes in the infrastructure to ensure it does not happen anymore.

It was detected also a build issue when security and log info were disabled. In this PR it has been introduced a CI job that builds Fast DDS without any additional arguments / flags, and the error fix has been introduced too.

Finally, building with warnings as error has been set also from the main CMakeLists.txt file.

Related eProsima-CI pr:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jul 18, 2024
@JesusPoderoso JesusPoderoso self-assigned this Jul 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 18, 2024
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima July 18, 2024 09:57
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima July 18, 2024 11:14
@JesusPoderoso JesusPoderoso requested review from richiprosima and removed request for richiprosima July 18, 2024 14:53
@JesusPoderoso JesusPoderoso changed the title [21307] Update example to build on windows [21387] Update example to build on windows Jul 18, 2024
@JesusPoderoso JesusPoderoso changed the title [21387] Update example to build on windows [21387] Fix Windows CI build and address build issues Jul 22, 2024
@MiguelCompany
Copy link
Member

@JesusPoderoso This needs a rebase, and fixing an unused variable warning on EDP.cpp

@JesusPoderoso JesusPoderoso requested review from MiguelCompany and removed request for richiprosima and MiguelCompany July 22, 2024 10:37
@JesusPoderoso JesusPoderoso requested review from MiguelCompany and removed request for MiguelCompany July 22, 2024 10:40
MiguelCompany
MiguelCompany previously approved these changes Jul 22, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany self-requested a review July 23, 2024 06:04
@MiguelCompany MiguelCompany force-pushed the hotfix/21307 branch 2 times, most recently from 2fe9d4b to 5269b2b Compare July 23, 2024 06:31
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 06:32
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 06:36
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany July 23, 2024 06:38
@MiguelCompany MiguelCompany merged commit 8341bdd into master Jul 23, 2024
15 of 17 checks passed
@MiguelCompany MiguelCompany deleted the hotfix/21307 branch July 23, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running first-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants