-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21387] Fix build issues and update CI infrastructure to detect them #5083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 18, 2024 09:57
2faff7f
to
d2ca5ab
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
July 18, 2024 09:57
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 18, 2024 11:14
d2ca5ab
to
1867006
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
July 18, 2024 11:14
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 18, 2024 14:53
1867006
to
7ddaf9d
Compare
JesusPoderoso
requested review from
richiprosima
and removed request for
richiprosima
July 18, 2024 14:53
JesusPoderoso
changed the title
[21307] Update example to build on windows
[21387] Update example to build on windows
Jul 18, 2024
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 19, 2024 11:19
7ddaf9d
to
999936c
Compare
JesusPoderoso
changed the title
[21387] Update example to build on windows
[21387] Fix Windows CI build and address build issues
Jul 22, 2024
@JesusPoderoso This needs a rebase, and fixing an unused variable warning on EDP.cpp |
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 22, 2024 10:37
999936c
to
c5bcddb
Compare
JesusPoderoso
requested review from
MiguelCompany
and removed request for
richiprosima and
MiguelCompany
July 22, 2024 10:37
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 22, 2024 10:39
c5bcddb
to
8840ab2
Compare
JesusPoderoso
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 22, 2024 10:40
MiguelCompany
approved these changes
Jul 22, 2024
MiguelCompany
requested changes
Jul 22, 2024
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 22, 2024 13:29
8340aac
to
c20c8b1
Compare
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 22, 2024 15:05
831aa88
to
749fc29
Compare
MiguelCompany
previously approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
5 tasks
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
MiguelCompany
force-pushed
the
hotfix/21307
branch
from
July 23, 2024 06:04
749fc29
to
cf3099c
Compare
JesusPoderoso
force-pushed
the
hotfix/21307
branch
from
July 23, 2024 06:26
e33a6c6
to
cf3099c
Compare
MiguelCompany
force-pushed
the
hotfix/21307
branch
2 times, most recently
from
July 23, 2024 06:31
2fe9d4b
to
5269b2b
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 23, 2024 06:32
MiguelCompany
force-pushed
the
hotfix/21307
branch
from
July 23, 2024 06:35
5269b2b
to
6596ebc
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 23, 2024 06:36
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
hotfix/21307
branch
from
July 23, 2024 06:37
3d788a2
to
75b8773
Compare
MiguelCompany
requested review from
MiguelCompany
and removed request for
MiguelCompany
July 23, 2024 06:38
MiguelCompany
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to an infrastructure issue with an internal action for Windows, the CI was not properly applying some CMake arguments while testing Fast DDS on Windows. Among others, the examples were not built, so CI passed even though.
This PR fixes the build issue, and tests the changes in the infrastructure to ensure it does not happen anymore.
It was detected also a build issue when security and log info were disabled. In this PR it has been introduced a CI job that builds Fast DDS without any additional arguments / flags, and the error fix has been introduced too.
Finally, building with warnings as error has been set also from the main CMakeLists.txt file.
Related eProsima-CI pr:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist