Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21301] Remove ReaderProxyData from public APIs #5078

Merged
merged 18 commits into from
Jul 18, 2024
Merged

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 16, 2024

Description

This PR makes ReaderProxyData an implementation detail of the library.
Changes include:

  • Moving SubscriptionBuiltinTopicData from fastdds::dds:builtin to fastdds::dds
  • Extending SubscriptionBuiltinTopicData with additional fields to mimick those of ReaderProxyData
  • Reader discovery callbacks changed to receive a reason and a SubscriptionBuiltinTopicData
  • Method fill_discovery_data_from_cdr_message now fills a SubscriptionBuiltinTopicData
  • Struct ReaderDiscoveryInfo has been removed
  • ReaderProxyData.hpp has been moved to src

Changes on related repos:

This PR depends on #5052 and must be merged after that one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one NIT. NO need for running ci again.
Also, update versions.md

src/cpp/rtps/builtin/data/ProxyDataConverters.hpp Outdated Show resolved Hide resolved
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
@Mario-DL Mario-DL self-requested a review July 18, 2024 05:57
Copy link
Member

@Mario-DL Mario-DL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 18, 2024
@MiguelCompany MiguelCompany merged commit 08f5f72 into master Jul 18, 2024
17 checks passed
@MiguelCompany MiguelCompany deleted the feature/21300 branch July 18, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants