Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21327] Mitigate LogTests.flush_n flakiness #5051

Merged
merged 3 commits into from
Jul 12, 2024
Merged

[21327] Mitigate LogTests.flush_n flakiness #5051

merged 3 commits into from
Jul 12, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented Jul 10, 2024 •
edited by JesusPoderoso
Loading

Description

This PR mitigates the flakiness of the LogTests.flush_n. Analysis showed that the conditions to assure that Log::Flush() is correctly synchronised with running exactly two times the Log::Run() were not fully correct. This PR tackles that and refactor the comments.

Reviewer can test running the test multiple times

@Mergifyio backport 2.14.x 2.10.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone Jul 10, 2024
@JesusPoderoso
Copy link
Contributor

JesusPoderoso commented Jul 10, 2024 •
edited
Loading

Manual runs of only the desired test for MacOS, Ubuntu and Windows triggered, with rerun test until failed 100 times.

@JesusPoderoso JesusPoderoso added the ci-pending PR which CI is running label Jul 11, 2024
JesusPoderoso
JesusPoderoso approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 11, 2024
@JesusPoderoso JesusPoderoso self-requested a review July 11, 2024 10:04
@JesusPoderoso JesusPoderoso removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 11, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 11, 2024
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jul 11, 2024
@JesusPoderoso
Copy link
Contributor

@Mergifyio backport 2.14.x 2.10.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024 •
edited
Loading

backport 2.14.x 2.10.x

✅ Backports have been created

@EduPonz EduPonz merged commit 77768eb into master Jul 12, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the bugfix/21327 branch July 12, 2024 05:19
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
@Mario-DL @mergify
Mitigate LogTests.flush_n flakiness (#5051)
552ae7c 
* Refs #21327: Fix LogTests.flush_n flakiness

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21327: TODO DROP THIS: add colcon test Dispatch argument

Signed-off-by: JesusPoderoso <[email protected]>

* Revert "Refs #21327: TODO DROP THIS: add colcon test Dispatch argument"

This reverts commit 48084a2.

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
(cherry picked from commit 77768eb)
mergify bot pushed a commit that referenced this pull request Jul 12, 2024
@Mario-DL @mergify
Mitigate LogTests.flush_n flakiness (#5051)
e009e25 
* Refs #21327: Fix LogTests.flush_n flakiness

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21327: TODO DROP THIS: add colcon test Dispatch argument

Signed-off-by: JesusPoderoso <[email protected]>

* Revert "Refs #21327: TODO DROP THIS: add colcon test Dispatch argument"

This reverts commit 48084a2.

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
(cherry picked from commit 77768eb)
This was referenced Jul 12, 2024
Merged
Merged
EduPonz pushed a commit that referenced this pull request Jul 15, 2024
@mergify @Mario-DL
Mitigate LogTests.flush_n flakiness (#5051) (#5063)
edc55d3 
* Refs #21327: Fix LogTests.flush_n flakiness

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21327: TODO DROP THIS: add colcon test Dispatch argument

Signed-off-by: JesusPoderoso <[email protected]>

* Revert "Refs #21327: TODO DROP THIS: add colcon test Dispatch argument"

This reverts commit 48084a2.

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
(cherry picked from commit 77768eb)

Co-authored-by: Mario Domínguez López <[email protected]>
MiguelCompany pushed a commit that referenced this pull request Jul 31, 2024
@mergify @Mario-DL
Mitigate LogTests.flush_n flakiness (#5051) (#5064)
45490ae 
* Refs #21327: Fix LogTests.flush_n flakiness

Signed-off-by: Mario Dominguez <[email protected]>

* Refs #21327: TODO DROP THIS: add colcon test Dispatch argument

Signed-off-by: JesusPoderoso <[email protected]>

* Revert "Refs #21327: TODO DROP THIS: add colcon test Dispatch argument"

This reverts commit 48084a2.

Signed-off-by: JesusPoderoso <[email protected]>

---------

Signed-off-by: Mario Dominguez <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Co-authored-by: JesusPoderoso <[email protected]>
(cherry picked from commit 77768eb)

Co-authored-by: Mario Domínguez López <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Mario-DL @JesusPoderoso @EduPonz