-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21186] Examples refactor: Topic Instances #5033
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 4, 2024 15:26
142b0db
to
f7a4cd6
Compare
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 9, 2024 15:24
5293219
to
74fe642
Compare
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 10, 2024 10:21
74fe642
to
b82d719
Compare
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 10, 2024 11:42
b82d719
to
74e200c
Compare
elianalf
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial revision
elianalf
suggested changes
Jul 12, 2024
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 15, 2024 09:03
f41ccdd
to
6049e6a
Compare
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
…sDemo) Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
…n to publisher Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
JesusPoderoso
force-pushed
the
feature/example_refactor/topic_instances
branch
from
July 19, 2024 11:26
815d97a
to
4c5fa90
Compare
Signed-off-by: JesusPoderoso <[email protected]>
elianalf
approved these changes
Jul 22, 2024
elianalf
added
the
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
label
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
ci-pending
PR which CI is running
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
In this topic instances example, the key changes are:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist