Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21186] Examples refactor: Topic Instances #5033

Merged
merged 26 commits into from
Jul 22, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Jul 4, 2024

Description

This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.

In this topic instances example, the key changes are:

  • shape type compatible with shapesdemo
  • use of keyed topics and instances
  • configuration of shape parameters

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Jul 4, 2024
@JesusPoderoso JesusPoderoso requested a review from elianalf July 4, 2024 15:20
@JesusPoderoso JesusPoderoso self-assigned this Jul 4, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 4, 2024
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 4, 2024 15:22
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from 142b0db to f7a4cd6 Compare July 4, 2024 15:26
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 4, 2024 15:26
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from 5293219 to 74fe642 Compare July 9, 2024 15:24
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 9, 2024 15:24
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from 74fe642 to b82d719 Compare July 10, 2024 10:21
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 10, 2024 10:21
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from b82d719 to 74e200c Compare July 10, 2024 11:42
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 10, 2024 11:42
Copy link
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Partial revision

examples/cpp/topic_instances/README.md Outdated Show resolved Hide resolved
examples/cpp/topic_instances/README.md Outdated Show resolved Hide resolved
examples/cpp/topic_instances/README.md Outdated Show resolved Hide resolved
examples/cpp/topic_instances/README.md Outdated Show resolved Hide resolved
examples/cpp/topic_instances/README.md Outdated Show resolved Hide resolved
examples/cpp/topic_instances/CLIParser.hpp Show resolved Hide resolved
examples/cpp/topic_instances/CLIParser.hpp Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.hpp Show resolved Hide resolved
examples/cpp/topic_instances/CLIParser.hpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.hpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/PublisherApp.cpp Show resolved Hide resolved
examples/cpp/topic_instances/SubscriberApp.cpp Outdated Show resolved Hide resolved
examples/cpp/topic_instances/SubscriberApp.cpp Outdated Show resolved Hide resolved
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from f41ccdd to 6049e6a Compare July 15, 2024 09:03
@JesusPoderoso JesusPoderoso requested a review from elianalf July 15, 2024 09:49
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso force-pushed the feature/example_refactor/topic_instances branch from 815d97a to 4c5fa90 Compare July 19, 2024 11:26
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 19, 2024 11:27
Signed-off-by: JesusPoderoso <[email protected]>
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf July 22, 2024 06:17
@elianalf elianalf added the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label Jul 22, 2024
@EduPonz EduPonz merged commit 7721943 into master Jul 22, 2024
13 of 17 checks passed
@EduPonz EduPonz deleted the feature/example_refactor/topic_instances branch July 22, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants