-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21137] RTPS writer APIs refactor #5028
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 3, 2024 13:26
0d10e60
to
b26d48d
Compare
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 4, 2024 08:03
b26d48d
to
30c4fb5
Compare
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 4, 2024 08:07
30c4fb5
to
e0fa7dd
Compare
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 5, 2024 06:32
dd3cba9
to
a021411
Compare
EduPonz
suggested changes
Jul 9, 2024
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 9, 2024 11:16
7eed767
to
fa1032b
Compare
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 9, 2024 12:32
b0b3b02
to
63155be
Compare
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
feature/21082/writer
branch
from
July 9, 2024 14:52
2f9a859
to
f421bf1
Compare
EduPonz
suggested changes
Jul 10, 2024
EduPonz
removed
needs-review
PR that is ready to be reviewed
ci-pending
PR which CI is running
labels
Jul 10, 2024
Signed-off-by: Miguel Company <[email protected]>
CI passed for f421bf1 |
EduPonz
approved these changes
Jul 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a refactor on the RTPS writer APIs, so only the ones intended for the user (i.e. public and exported) are present.
The refactor includes adding an intermediate
BaseWriter
class with the internal APIs.Related PRs:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist