Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21137] RTPS writer APIs refactor #5028

Merged
merged 44 commits into from
Jul 10, 2024
Merged

[21137] RTPS writer APIs refactor #5028

merged 44 commits into from
Jul 10, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jul 3, 2024

Description

This is a refactor on the RTPS writer APIs, so only the ones intended for the user (i.e. public and exported) are present.
The refactor includes adding an intermediate BaseWriter class with the internal APIs.

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A: If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jul 3, 2024
@MiguelCompany MiguelCompany requested a review from EduPonz July 3, 2024 13:14
@github-actions github-actions bot added the ci-pending PR which CI is running label Jul 3, 2024
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from 0d10e60 to b26d48d Compare July 3, 2024 13:26
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 3, 2024 13:27
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from b26d48d to 30c4fb5 Compare July 4, 2024 08:03
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 4, 2024 08:04
@MiguelCompany MiguelCompany added the needs-review PR that is ready to be reviewed label Jul 4, 2024
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from 30c4fb5 to e0fa7dd Compare July 4, 2024 08:07
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 4, 2024 08:07
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 4, 2024 12:22
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from dd3cba9 to a021411 Compare July 5, 2024 06:32
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 5, 2024 06:35
src/cpp/rtps/builtin/liveliness/WLP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/participant/RTPSParticipantImpl.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/BaseWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/BaseWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/BaseWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/BaseWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatefulWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatelessWriter.hpp Outdated Show resolved Hide resolved
src/cpp/fastdds/publisher/DataWriterImpl.hpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from 7eed767 to fa1032b Compare July 9, 2024 11:16
@MiguelCompany MiguelCompany requested a review from EduPonz July 9, 2024 12:28
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from b0b3b02 to 63155be Compare July 9, 2024 12:32
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
@MiguelCompany MiguelCompany force-pushed the feature/21082/writer branch from 2f9a859 to f421bf1 Compare July 9, 2024 14:52
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for EduPonz July 9, 2024 14:56
@EduPonz EduPonz removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jul 10, 2024
Signed-off-by: Miguel Company <[email protected]>
@EduPonz
Copy link

EduPonz commented Jul 10, 2024

CI passed for f421bf1

@MiguelCompany MiguelCompany merged commit a73448d into master Jul 10, 2024
3 checks passed
@MiguelCompany MiguelCompany deleted the feature/21082/writer branch July 10, 2024 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants