-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21188] Example Refactor: Request-Reply #5014
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianalf
changed the title
[21188] Request-Reply example
[21188] Example Refactor: Request-Reply
Jul 1, 2024
elianalf
suggested changes
Jul 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
The include of the subdirectory RequestReplyExample
has not been removed from /exampels/cpp/dds/CMakeLists.txt.
elianalf
suggested changes
Jul 3, 2024
EduPonz
force-pushed
the
examples/request_reply
branch
from
July 10, 2024 12:59
e120b12
to
05ba0c0
Compare
EduPonz
force-pushed
the
examples/request_reply
branch
from
July 12, 2024 08:35
caecb71
to
0002ccb
Compare
Another manual CI here |
Another manual try here |
elianalf
suggested changes
Jul 15, 2024
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…eplies Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…os_from_default_profile Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…docker compose versions Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
EduPonz
force-pushed
the
examples/request_reply
branch
from
July 15, 2024 14:19
b32b2b6
to
130a911
Compare
elianalf
approved these changes
Jul 16, 2024
elianalf
added
the
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
label
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the request-reply example.
It also adds a
Add DomainParticipantFactory::get_participant_extended_qos_from_default_profile
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist