Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21223] Fix parse XML member dynamic type fuzzer issue #5007

Merged
merged 3 commits into from
Jul 2, 2024
Merged

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Jun 28, 2024

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • N/A If this is a critical bug fix, backports to the critical-only supported branches have been requested.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Jun 28, 2024
@elianalf elianalf marked this pull request as ready for review June 28, 2024 10:18
@elianalf elianalf requested a review from EduPonz June 28, 2024 10:19
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 28, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label Jul 1, 2024
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a NIT that does not require CI (I've added skip-ci

src/cpp/xmlparser/XMLDynamicParser.cpp Outdated Show resolved Hide resolved
@EduPonz EduPonz added skip-ci Automatically pass CI and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jul 1, 2024
@EduPonz EduPonz self-requested a review July 2, 2024 09:53
@EduPonz EduPonz merged commit 379da7d into master Jul 2, 2024
7 checks passed
@EduPonz EduPonz deleted the hotfix/21223 branch July 2, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants