-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21137] RTPS WriterHistory
refactor
#4966
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 06:40
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 19, 2024 08:31
60154a1
to
722bcc5
Compare
MiguelCompany
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 08:31
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 19, 2024 09:02
722bcc5
to
dcac228
Compare
MiguelCompany
changed the title
RTPS
[21137] RTPS Jun 19, 2024
WriterHistory
refactorWriterHistory
refactor
MiguelCompany
requested review from
richiprosima
and removed request for
richiprosima
June 19, 2024 09:02
MiguelCompany
force-pushed
the
feature/21082/history
branch
3 times, most recently
from
June 19, 2024 14:53
1af45c5
to
b4e4ef8
Compare
MiguelCompany
requested review from
EduPonz
and removed request for
richiprosima
June 19, 2024 14:53
@richiprosima Please test_3 discovery-server |
EduPonz
suggested changes
Jun 25, 2024
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 25, 2024 12:28
b4e4ef8
to
9c8c090
Compare
JesusPoderoso
force-pushed
the
feature/21128
branch
from
June 25, 2024 13:19
545d325
to
3173ddf
Compare
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 25, 2024 15:10
9c8c090
to
d2cacd9
Compare
JesusPoderoso
force-pushed
the
feature/21128
branch
from
June 26, 2024 07:01
7face26
to
7d6f6b5
Compare
EduPonz
approved these changes
Jun 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI and versions.md update
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 26, 2024 09:50
d2cacd9
to
9a741c2
Compare
MiguelCompany
added
the
doc-pending
Issue or PR which is pending to be documented
label
Jun 26, 2024
MiguelCompany
force-pushed
the
feature/21082/history
branch
from
June 26, 2024 10:16
9a741c2
to
9b4108d
Compare
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]> Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
EduPonz
force-pushed
the
feature/21082/history
branch
from
June 27, 2024 05:29
f0433b6
to
f614bb3
Compare
Signed-off-by: eduponz <[email protected]>
EduPonz
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
Jun 27, 2024
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR changes the responsibility of managing the change and payload pools from the
RTPSWriter
to theWriterHistory
This PR depends on #4958 and must be merged after that one.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist