Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21137] RTPS WriterHistory refactor #4966

Merged
merged 45 commits into from
Jun 27, 2024
Merged

[21137] RTPS WriterHistory refactor #4966

merged 45 commits into from
Jun 27, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented Jun 18, 2024

Description

This PR changes the responsibility of managing the change and payload pools from the RTPSWriter to the WriterHistory

This PR depends on #4958 and must be merged after that one.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone Jun 18, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 18, 2024
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 06:40
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from 60154a1 to 722bcc5 Compare June 19, 2024 08:31
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 08:31
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from 722bcc5 to dcac228 Compare June 19, 2024 09:02
@MiguelCompany MiguelCompany changed the title RTPS WriterHistory refactor [21137] RTPS WriterHistory refactor Jun 19, 2024
@MiguelCompany MiguelCompany requested review from richiprosima and removed request for richiprosima June 19, 2024 09:02
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch 3 times, most recently from 1af45c5 to b4e4ef8 Compare June 19, 2024 14:53
@MiguelCompany MiguelCompany requested review from EduPonz and removed request for richiprosima June 19, 2024 14:53
@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 discovery-server

include/fastdds/rtps/history/WriterHistory.h Outdated Show resolved Hide resolved
src/cpp/rtps/history/WriterHistory.cpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from b4e4ef8 to 9c8c090 Compare June 25, 2024 12:28
@MiguelCompany MiguelCompany changed the base branch from master to feature/21128 June 25, 2024 12:29
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from 9c8c090 to d2cacd9 Compare June 25, 2024 15:10
@EduPonz EduPonz self-requested a review June 26, 2024 08:45
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI and versions.md update

@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from d2cacd9 to 9a741c2 Compare June 26, 2024 09:50
@MiguelCompany MiguelCompany added the doc-pending Issue or PR which is pending to be documented label Jun 26, 2024
@MiguelCompany MiguelCompany force-pushed the feature/21082/history branch from 9a741c2 to 9b4108d Compare June 26, 2024 10:16
MiguelCompany and others added 18 commits June 27, 2024 07:23
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>

Co-authored-by: Eduardo Ponz Segrelles <[email protected]>
@EduPonz EduPonz force-pushed the feature/21082/history branch from f0433b6 to f614bb3 Compare June 27, 2024 05:29
@EduPonz EduPonz removed the temporarily-blocked PR must be merged after another one label Jun 27, 2024
@EduPonz EduPonz self-requested a review June 27, 2024 05:35
@EduPonz EduPonz requested review from EduPonz and removed request for EduPonz June 27, 2024 08:08
@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels Jun 27, 2024
@EduPonz EduPonz merged commit d3ca40c into master Jun 27, 2024
23 of 31 checks passed
@EduPonz EduPonz deleted the feature/21082/history branch June 27, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants