-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21198] Add product version on Participant Discovery information #4964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richiware
changed the title
Add product version on Participant Discovery information
Add product version on Participant Discovery information [21198]
Jun 18, 2024
rsanchez15
changed the title
Add product version on Participant Discovery information [21198]
[21198] Add product version on Participant Discovery information
Jul 22, 2024
juanlofer-eprosima
requested changes
Jul 24, 2024
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
Signed-off-by: Ricardo González Moreno <[email protected]>
richiware
force-pushed
the
feature/21197
branch
2 times, most recently
from
July 26, 2024 10:04
b033664
to
9f15e5a
Compare
Signed-off-by: Ricardo González Moreno <[email protected]>
juanlofer-eprosima
requested review from
juanlofer-eprosima
and removed request for
juanlofer-eprosima
July 26, 2024 10:20
juanlofer-eprosima
previously approved these changes
Jul 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Ricardo González Moreno <[email protected]>
juanlofer-eprosima
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new custom pid PID_PRODUCT_VERSION (0x8000) used to send the Fast DDS version.
Depends on:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist