-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21183] const
qualify all data related inputs in DataWriter APIs
#4960
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Types under test/profiling
folder need to be updated
3e8d288
to
91378b3
Compare
91378b3
to
6cbb5ff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
6cbb5ff
to
c781520
Compare
…r APIs Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
Signed-off-by: eduponz <[email protected]>
…as override Signed-off-by: eduponz <[email protected]>
c781520
to
bf46800
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A nit that does not require running CI again
Signed-off-by: eduponz <[email protected]>
Description
This PR qualifies all the data related inputs from
DataWriter
API asconst
.Related PRs:
const
qualification of all data related inputs in DataWriter APIs Fast-DDS-Gen#357const
qualification of all data related inputs in DataWriter APIs Fast-DDS-python#142const
qualification of all data related inputs in DataWriter APIs Fast-DDS-docs#817const
qualification of all data related inputs in DataWriter APIs ShapesDemo#147const
qualification of all data related inputs in DataWriter APIs Discovery-Server#88Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist