Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21183] const qualify all data related inputs in DataWriter APIs #4960

Merged
merged 13 commits into from
Jun 21, 2024

Conversation

EduPonz
Copy link

@EduPonz EduPonz commented Jun 18, 2024

Description

This PR qualifies all the data related inputs from DataWriter API as const.

Related PRs:

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A: Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A: Any new/modified methods have been properly documented using Doxygen.
  • N/A: Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A: New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A: Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Types under test/profiling folder need to be updated

@EduPonz EduPonz force-pushed the feature/const_datawriter_api branch from 3e8d288 to 91378b3 Compare June 19, 2024 09:24
@EduPonz EduPonz requested a review from MiguelCompany June 19, 2024 09:31
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 19, 2024
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany June 19, 2024 09:45
test/profiling/MemoryTestTypes.cpp Outdated Show resolved Hide resolved
@EduPonz EduPonz force-pushed the feature/const_datawriter_api branch from 91378b3 to 6cbb5ff Compare June 19, 2024 10:08
@EduPonz EduPonz requested a review from MiguelCompany June 19, 2024 10:09
MiguelCompany
MiguelCompany previously approved these changes Jun 19, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

MiguelCompany
MiguelCompany previously approved these changes Jun 19, 2024
@EduPonz EduPonz force-pushed the feature/const_datawriter_api branch from c781520 to bf46800 Compare June 20, 2024 06:45
@EduPonz EduPonz requested review from MiguelCompany and removed request for MiguelCompany June 20, 2024 06:46
MiguelCompany
MiguelCompany previously approved these changes Jun 21, 2024
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A nit that does not require running CI again

src/cpp/fastdds/domain/DomainParticipantImpl.cpp Outdated Show resolved Hide resolved
@EduPonz EduPonz added skip-ci Automatically pass CI and removed ci-pending PR which CI is running labels Jun 21, 2024
@EduPonz EduPonz merged commit 60a8b11 into master Jun 21, 2024
2 of 3 checks passed
@EduPonz EduPonz deleted the feature/const_datawriter_api branch June 21, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-ci Automatically pass CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants