Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20650] Create InitialConnection for TCP initial peers 3.x & 2.14 #4946

Merged
merged 2 commits into from
Jun 25, 2024
Merged

[20650] Create InitialConnection for TCP initial peers 3.x & 2.14 #4946

merged 2 commits into from
Jun 25, 2024

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented Jun 14, 2024 •
edited by JesusPoderoso
Loading

Description

This PR uses the features introduced in #4586 to ALWAYS create a connection channel for the TCP when initial peers are configured.

@Mergifyio backport 2.14.x

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport ONLY FOR 2.14 compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@cferreiragonz cferreiragonz added the needs-review PR that is ready to be reviewed label Jun 14, 2024
@cferreiragonz cferreiragonz added this to the v3.0.0 milestone Jun 14, 2024
@cferreiragonz cferreiragonz marked this pull request as ready for review June 14, 2024 06:46
@cferreiragonz
Copy link
Contributor Author

@Mergifyio backport 2.14.x

@mergify Mergify
Copy link
Contributor

mergify bot commented Jun 14, 2024 •
edited
Loading

backport 2.14.x

✅ Backports have been created

@cferreiragonz cferreiragonz force-pushed the bugfix/initial_peers_tcp branch 2 times, most recently from 7c09a7d to acdb709 Compare June 18, 2024 14:55
@cferreiragonz cferreiragonz force-pushed the bugfix/initial_peers_tcp branch from acdb709 to f37ff3d Compare June 18, 2024 15:03
@cferreiragonz cferreiragonz requested review from JesusPoderoso and removed request for JesusPoderoso June 20, 2024 07:19
@github-actions github-actions bot added the ci-pending PR which CI is running label Jun 20, 2024
@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels Jun 25, 2024
JesusPoderoso
JesusPoderoso approved these changes Jun 25, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EduPonz EduPonz merged commit 068092b into master Jun 25, 2024
16 of 17 checks passed
@EduPonz EduPonz deleted the bugfix/initial_peers_tcp branch June 25, 2024 12:28
mergify bot pushed a commit that referenced this pull request Jun 25, 2024
@cferreiragonz @mergify
Create InitialConnection for TCP initial peers 3.x & 2.14 (#4946)
42d1de6 
* Refs #20650: Add test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #20650: Use OpenOutputChannels for initialPeers

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 068092b)
@mergify mergify bot mentioned this pull request Jun 25, 2024
Merged
10 tasks
cferreiragonz added a commit that referenced this pull request Jun 26, 2024
@cferreiragonz
Create InitialConnection for TCP initial peers 3.x & 2.14 (#4946)
7dc89c8 
* Refs #20650: Add test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #20650: Use OpenOutputChannels for initialPeers

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 068092b)
EduPonz pushed a commit that referenced this pull request Jul 3, 2024
@mergify @cferreiragonz
Create InitialConnection for TCP initial peers 3.x & 2.14 (#4946) (#4998
176b5c3 
)

* Refs #20650: Add test

Signed-off-by: cferreiragonz <[email protected]>

* Refs #20650: Use OpenOutputChannels for initialPeers

Signed-off-by: cferreiragonz <[email protected]>

---------

Signed-off-by: cferreiragonz <[email protected]>
(cherry picked from commit 068092b)

Co-authored-by: Carlos Ferreira González <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@cferreiragonz @JesusPoderoso @EduPonz