-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20849] New max_message_size
property to limit output datagrams size (backport #4777) (backport #4807)
#4899
Conversation
Cherry-pick of 0571391 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
@elianalf would you mind addressing the conflicts here ? |
41bd5a0
to
c9cdbd8
Compare
#4807) * Refs #20489. Parse property in RTPS writer. Signed-off-by: Miguel Company <[email protected]> * Refs #20849. Parse property in RTPS participant. Signed-off-by: Miguel Company <[email protected]> * Refs #20849: Add test for RTPS writer Signed-off-by: elianalf <[email protected]> * Refs #20849: Add test for participant Signed-off-by: elianalf <[email protected]> * Refs #20849: Apply suggestions Signed-off-by: elianalf <[email protected]> * Refs #20849: Uncrustify Signed-off-by: elianalf <[email protected]> * Refs #20849: Apply suggestions Signed-off-by: elianalf <[email protected]> * Refs #20849: Add tests in DDS layer Signed-off-by: elianalf <[email protected]> * Refs #20849: Apply suggestions Signed-off-by: elianalf <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> Signed-off-by: elianalf <[email protected]> Co-authored-by: Miguel Company <[email protected]> (cherry picked from commit 6d20b64) Co-authored-by: elianalf <[email protected]> (cherry picked from commit 0571391)
Signed-off-by: elianalf <[email protected]>
c9cdbd8
to
2b80553
Compare
Signed-off-by: elianalf <[email protected]>
@richiprosima please test discovery-server |
I have ordered another windows rerun to assure that the two failed tests are not deterministic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated failed tests
Description
This PR adds the parsing of
max_message_size
property in RTPS Writer and RTPS Participant.@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Contributor Checklist
versions.md
file (if applicable).max_message_size
property to limit output datagrams size Fast-DDS-docs#770Reviewer Checklist
This is an automatic backport of pull request #4777 done by [Mergify](https://mergify.com).
This is an automatic backport of pull request #4807 done by [Mergify](https://mergify.com).