Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21098] Make StdoutErrConsumer default #4873

Merged
merged 2 commits into from
Jun 4, 2024
Merged

[21098] Make StdoutErrConsumer default #4873

merged 2 commits into from
Jun 4, 2024

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 29, 2024

Description

This PR makes StdoutErrConsumer the default LogConsumer .

I doubted whether this feature is to be backported, will be discussed with the reviewer.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
  • NO Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@Mario-DL Mario-DL added this to the v3.0.0 milestone May 29, 2024
@Mario-DL Mario-DL marked this pull request as ready for review May 29, 2024 14:21
@Mario-DL Mario-DL requested a review from richiprosima May 29, 2024 14:28
@github-actions github-actions bot added the ci-pending PR which CI is running label May 29, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label May 30, 2024
MiguelCompany
MiguelCompany previously approved these changes Jun 3, 2024
@MiguelCompany
Copy link
Member

@Mario-DL After CI passes, please rebase and fix the conflict in versions.md. We don't need to pass CI again for this to be merged

Mario-DL added 2 commits June 4, 2024 14:47
@MiguelCompany MiguelCompany merged commit 2494263 into master Jun 4, 2024
2 checks passed
@MiguelCompany MiguelCompany deleted the feature/21098 branch June 4, 2024 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants