Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix PDP & EDP unittest compilation #4871

Merged
merged 1 commit into from
May 30, 2024
Merged

Conversation

Mario-DL
Copy link
Member

@Mario-DL Mario-DL commented May 29, 2024

Description

This PR fixes a compilation issue with gmock and PDP/EDPTests unittests. It seems that ParticipantSecurityAttributes were just forward declared.

Note: compiling google-distribution release-1.11.0 solves the issue.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • NO Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • NO Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • NO Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • NO Changes are API compatible.
  • NO New feature has been added to the versions.md file (if applicable).
  • NO New feature has been documented/Current behavior is correctly described in the documentation.
  • Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

Signed-off-by: Mario Dominguez <[email protected]>
@Mario-DL Mario-DL added this to the v3.0.0 milestone May 29, 2024
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label May 29, 2024
@MiguelCompany MiguelCompany self-requested a review May 29, 2024 10:57
@github-actions github-actions bot added the ci-pending PR which CI is running label May 29, 2024
@MiguelCompany MiguelCompany marked this pull request as ready for review May 29, 2024 10:58
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed no-test Skip CI tests if PR marked with this label ci-pending PR which CI is running labels May 30, 2024
@MiguelCompany MiguelCompany merged commit b225800 into master May 30, 2024
8 checks passed
@MiguelCompany MiguelCompany deleted the fix/compilation-unittests branch May 30, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants