-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20821] Make rtps writer impl private #4869
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianalf
force-pushed
the
feature/make_rtps_writer_impl_private
branch
from
May 29, 2024 06:13
a21e1f0
to
cc3106a
Compare
MiguelCompany
requested changes
May 29, 2024
MiguelCompany
previously approved these changes
May 29, 2024
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
elianalf
force-pushed
the
feature/make_rtps_writer_impl_private
branch
from
May 30, 2024 14:23
d6190fa
to
1214bd9
Compare
elianalf
requested review from
MiguelCompany
and removed request for
MiguelCompany
May 30, 2024 14:24
MiguelCompany
approved these changes
May 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes RTPS Writer implementations private:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist