Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20821] Make rtps writer impl private #4869

Merged
merged 6 commits into from
May 30, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented May 29, 2024

Description

This PR makes RTPS Writer implementations private:

  • PersistentWriter
  • StatefulPersistentWriter
  • StatefulWriter
  • StatelessPersistentWriter
  • StatelessWriter

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone May 29, 2024
@elianalf elianalf force-pushed the feature/make_rtps_writer_impl_private branch from a21e1f0 to cc3106a Compare May 29, 2024 06:13
@MiguelCompany MiguelCompany self-requested a review May 29, 2024 07:03
@github-actions github-actions bot added the ci-pending PR which CI is running label May 29, 2024
src/cpp/rtps/writer/StatefulPersistentWriter.hpp Outdated Show resolved Hide resolved
src/cpp/rtps/writer/StatelessPersistentWriter.hpp Outdated Show resolved Hide resolved
test/unittest/dds/publisher/DataWriterTests.cpp Outdated Show resolved Hide resolved
test/unittest/dds/publisher/DataWriterTests.cpp Outdated Show resolved Hide resolved
@MiguelCompany MiguelCompany self-requested a review May 29, 2024 12:04
MiguelCompany
MiguelCompany previously approved these changes May 29, 2024
@elianalf elianalf force-pushed the feature/make_rtps_writer_impl_private branch from d6190fa to 1214bd9 Compare May 30, 2024 14:23
@elianalf elianalf requested review from MiguelCompany and removed request for MiguelCompany May 30, 2024 14:24
Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@MiguelCompany MiguelCompany merged commit 1925a6b into master May 30, 2024
10 of 11 checks passed
@MiguelCompany MiguelCompany deleted the feature/make_rtps_writer_impl_private branch May 30, 2024 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants