Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21055] Automatically unmatch remote participants on participant deletion #4817

Merged
merged 9 commits into from
May 27, 2024

Conversation

MiguelCompany
Copy link
Member

@MiguelCompany MiguelCompany commented May 21, 2024

Description

It's been reported that when several participants are created in the same process, and log warnings are enabled, a call to delete_participant() triggers the following warning several times:

[RTPS_READER Warning] Automatically unmatching on ~WriterProxy -> Function ~WriterProxy

Debugging revealed that these were shown for the built-in reliable readers.

This PR adds a mechanism to automatically unmatch the built-in endpoints when a participant is deleted.
The mechanism consists of performing the same actions executed when receiving a DATA(p|UD), without triggering the participant listener.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • [NO] Applicable backports have been included in the description.
    • Backport to 2.14.x will be done manually, and we will backport to the supported branches from that one

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@MiguelCompany MiguelCompany added this to the v3.0.0 milestone May 21, 2024
@MiguelCompany MiguelCompany requested a review from elianalf May 21, 2024 09:05
@github-actions github-actions bot added the ci-pending PR which CI is running label May 21, 2024
@MiguelCompany MiguelCompany requested review from elianalf and removed request for elianalf May 21, 2024 09:08
@MiguelCompany MiguelCompany requested review from elianalf and removed request for elianalf May 21, 2024 09:31
@MiguelCompany
Copy link
Member Author

@richiprosima Please test_3 this

src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/discovery/participant/PDP.cpp Outdated Show resolved Hide resolved
src/cpp/rtps/builtin/BuiltinProtocols.cpp Outdated Show resolved Hide resolved
@elianalf
Copy link
Contributor

@richiprosima please test_3 this

@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 27, 2024
@MiguelCompany MiguelCompany merged commit e3c1541 into master May 27, 2024
13 of 15 checks passed
@MiguelCompany MiguelCompany deleted the bugfix/19764 branch May 27, 2024 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants