-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[21055] Automatically unmatch remote participants on participant deletion #4817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiguelCompany
force-pushed
the
bugfix/19764
branch
from
May 21, 2024 09:07
4e89943
to
9c98255
Compare
MiguelCompany
force-pushed
the
bugfix/19764
branch
from
May 21, 2024 09:31
9c98255
to
406f3b8
Compare
@richiprosima Please test_3 this |
elianalf
suggested changes
May 22, 2024
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
…tocols`. Signed-off-by: Miguel Company <[email protected]>
…ticipants. Signed-off-by: Miguel Company <[email protected]>
MiguelCompany
force-pushed
the
bugfix/19764
branch
from
May 24, 2024 07:26
406f3b8
to
a37cec9
Compare
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
Signed-off-by: Miguel Company <[email protected]>
12 tasks
elianalf
approved these changes
May 27, 2024
@richiprosima please test_3 this |
elianalf
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
May 27, 2024
10 tasks
This was referenced May 28, 2024
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It's been reported that when several participants are created in the same process, and log warnings are enabled, a call to
delete_participant()
triggers the following warning several times:[RTPS_READER Warning] Automatically unmatching on ~WriterProxy -> Function ~WriterProxy
Debugging revealed that these were shown for the built-in reliable readers.
This PR adds a mechanism to automatically unmatch the built-in endpoints when a participant is deleted.
The mechanism consists of performing the same actions executed when receiving a DATA(p|UD), without triggering the participant listener.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist