-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix compilation when building static library [21059] #4813
Conversation
Manual build with |
@Mergifyio rebase |
✅ Branch has been successfully rebased |
5b70fab
to
942bf2a
Compare
@richiware Build failed when linking in this manual run where I passed |
Signed-off-by: Ricardo González Moreno <[email protected]>
@richiprosima Please test_3 discovery-server |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green build.
Local build with -DBUILD_SHARED_LIBS=OFF success on windows and Ubuntu
@Mergifyio rebase |
☑️ Nothing to do
|
@richiprosima Please test_3 discovery-server |
@richiprosima please test_3 linux |
@richiprosima Please test_3 discovery-server |
Description
Static library generation is not working in 3.x. This PR fixes it.
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist