Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compilation when building static library [21059] #4813

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Conversation

richiware
Copy link
Member

@richiware richiware commented May 20, 2024

Description

Static library generation is not working in 3.x. This PR fixes it.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware changed the title Fix compilation when building static library Fix compilation when building static library [21059] May 20, 2024
@JesusPoderoso JesusPoderoso self-requested a review May 20, 2024 10:06
@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone May 20, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 20, 2024
@MiguelCompany MiguelCompany added the no-test Skip CI tests if PR marked with this label label May 20, 2024
@MiguelCompany MiguelCompany self-requested a review May 20, 2024 10:17
@MiguelCompany
Copy link
Member

MiguelCompany commented May 20, 2024

Manual build with -DBUILD_SHARED_LIBS=OFF:

@MiguelCompany
Copy link
Member

@Mergifyio rebase

Copy link
Contributor

mergify bot commented May 27, 2024

rebase

✅ Branch has been successfully rebased

@MiguelCompany
Copy link
Member

@richiware Build failed when linking in this manual run where I passed -DBUILD_SHARED_LIBS=OFF

Signed-off-by: Ricardo González Moreno <[email protected]>
@MiguelCompany MiguelCompany requested review from MiguelCompany and removed request for MiguelCompany and JesusPoderoso June 3, 2024 12:38
@MiguelCompany
Copy link
Member

@richiprosima Please test_3 discovery-server

Copy link
Member

@MiguelCompany MiguelCompany left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green build.

Local build with -DBUILD_SHARED_LIBS=OFF success on windows and Ubuntu

@MiguelCompany
Copy link
Member

@Mergifyio rebase

Copy link
Contributor

mergify bot commented Jun 3, 2024

rebase

☑️ Nothing to do

  • any of:
    • #commits-behind>0 [📌 rebase requirement]
    • #commits>1 [📌 rebase requirement]
    • -linear-history [📌 rebase requirement]
  • -closed [📌 rebase requirement]
  • -conflict [📌 rebase requirement]
  • queue-position=-1 [📌 rebase requirement]

@MiguelCompany
Copy link
Member

@richiprosima Please test_3 discovery-server

@MiguelCompany
Copy link
Member

@richiprosima please test_3 linux

@elianalf
Copy link
Contributor

elianalf commented Jun 4, 2024

@richiprosima Please test_3 discovery-server

@EduPonz EduPonz merged commit 74acbb8 into master Jun 4, 2024
9 of 10 checks passed
@EduPonz EduPonz deleted the bugfix/21038 branch June 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running no-test Skip CI tests if PR marked with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants