[20658] Fix leak in SecurityManager::participant_volatile_message_secure_writer_ (backport #4673)
#4726
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
…er_ (#4673) * Refs #20658. Add blackbox test. Signed-off-by: Miguel Company <[email protected]> * Refs #20658. Add expectations to unit test. Signed-off-by: Miguel Company <[email protected]> * Refs #20658. Fix issue. Signed-off-by: Miguel Company <[email protected]> * Refs #20658. Improve regression test. Signed-off-by: Miguel Company <[email protected]> --------- Signed-off-by: Miguel Company <[email protected]> (cherry picked from commit 14ee8ef)
12 tasks
Signed-off-by: Mario Dominguez <[email protected]>
|
@richiprosima please test this |
Mario-DL
approved these changes
May 7, 2024
Mario-DL
added
the
ready-to-merge
|
Gtihub failing tests unrelated to this PR, known flakies on windows and mac. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a fix for #4553, which reported an increase in memory consumption when the partition of a secure DataWriter is changed. The consumption came from the history of the
participant_volatile_message_secure_writer_not being correctly cleared.This PR:
TopicPayloadPoolmemory leak problem #4553volatile_writer_in the security tests into aStrictMock, and adds expectations for the added change to be releasedTopicPayloadPoolmemory leak problem #4553 by makingSecurityManagerimplementrtps::WriterListenerand removing changes from history when they are acknowledged (i.e. makingparticipant_volatile_message_secure_writer_truly behave as volatile)@Mergifyio backport 2.13.x 2.10.x 2.6.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.mdfile (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4673 done by [Mergify](https://mergify.com).