-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20629] GUIDLess Discovery Server #4716
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
April 23, 2024 13:15
dcea616
to
5209472
Compare
7 tasks
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
2 times, most recently
from
April 26, 2024 11:01
f90602a
to
a12d3ef
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
2 times, most recently
from
May 6, 2024 11:06
dcc705f
to
6380fb3
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
May 6, 2024 11:11
6380fb3
to
77acce1
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
May 7, 2024 05:53
77acce1
to
4d2244d
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
May 10, 2024 11:09
2f68ecc
to
105294a
Compare
11 tasks
cferreiragonz
force-pushed
the
bugfix/backup_restore
branch
from
May 13, 2024 08:16
a2ab9b9
to
1a59486
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
May 13, 2024 08:16
105294a
to
a9dfd62
Compare
cferreiragonz
force-pushed
the
bugfix/backup_restore
branch
from
May 14, 2024 08:20
1a59486
to
2481446
Compare
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
May 14, 2024 08:28
a9dfd62
to
904b75b
Compare
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
…scovery of TST Signed-off-by: cferreiragonz <[email protected]>
Signed-off-by: cferreiragonz <[email protected]>
cferreiragonz
force-pushed
the
feature/mesh_ds_guid_less_3.0.x
branch
from
June 28, 2024 06:45
09e9f9a
to
688cd0f
Compare
cferreiragonz
requested review from
richiprosima
and removed request for
richiprosima
June 28, 2024 06:49
MiguelCompany
requested changes
Jul 1, 2024
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
previously approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
MiguelCompany
added
versions-pending
and removed
needs-review
PR that is ready to be reviewed
labels
Jul 1, 2024
Signed-off-by: cferreiragonz <[email protected]>
MiguelCompany
previously approved these changes
Jul 2, 2024
Signed-off-by: cferreiragonz <[email protected]>
Green CI. Updating |
MiguelCompany
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
versions-pending
labels
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR drastically changes Discovery Server behavior to be able to work without a fixed GUID.
Servers and Clients now connect between each other by exclusively specifying a locator, the GUID is not needed anymore. The remote server list has been replaced with LocatorList.
Hence, the server_id parameter used in the CLI and the positional arguments in the environment variable are deprecated. The -i parameter in the CLI has been kept in order to guarantee backward compatibility, but it is not mandatory any longer.
Servers now use a mesh topology, meaning that every server will directly connect with all of the available servers.
In order to accomplish last point, Servers now send the Data(p) of connected servers to new servers connections and send the Data(p) of the new server to all connected servers. To connect a new server to the mesh, it is only needed to specify the locator of an already connected server.
Servers only redirect discovery information of their direct clients, and will stop redirecting discovery information of the clients of other servers.
Remote Discovery servers connection list can now be updated at runtime without any restrictions. The previous list does not need to be a subset of the new one.
Servers now use the lease announcements routine to make connections with the remote servers specified in the remote Discovery servers list. Initial announcements will be called again every time a known server is dropped or the remote server list is updated.
Clients now accept connections of any server, not only the ones specified in their remote Discovery servers list. Although in normal behavior a client will only receive discovery information of the servers pinged by itself, if it receives a Data(p) of an other server (sending it manually) it will try to make a connection.
ServerAttributes is now private, as it is no longer needed to configure Clients or Servers
This PR is on top of [20936] Change backup restore order #4740 and must be merged after it
It also affects the python API: [20629] GUIDLess Discovery Server - Make ServerAttributes private Fast-DDS-python#147
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist