Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20817] Remove unnecessary header and make private SecurityException and Exception #4701

Merged
merged 10 commits into from
May 30, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented Apr 18, 2024

Description

This PR
Remove:

  • all_common.h
  • fastdds/rtps/network/SenderResource.h
  • DomainParticipant::get_resource_event
  • fastrtps/Exception.h
  • rtps_fwd.h

Make private:

  • SecurityException
  • Exception

Move the implementation of LoggingLevel to .cpp in /src

Related PR

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are ABI compatible.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    - Related documentation PR: [20817] Remove exception api Fast-DDS-docs#785
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone Apr 18, 2024
@elianalf elianalf changed the title Remove unnecessary header and make private SecurityException and Exception [20817] Remove unnecessary header and make private SecurityException and Exception Apr 18, 2024
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 3 times, most recently from 5148f5d to bd83bb2 Compare April 23, 2024 05:52
@elianalf elianalf added needs-review PR that is ready to be reviewed needs rebase labels Apr 29, 2024
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:27
@elianalf elianalf force-pushed the feature/remove_miscellaneous_api branch from 8ed9e38 to 7cb1a23 Compare May 16, 2024 14:56
Copy link

@EduPonz EduPonz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small NIT. Also, this has conflicts now, please rebase. It seems that ShapesDemo does not build with this, neither does Fast DDS Python

src/cpp/rtps/security/logging/LoggingLevel.cpp Outdated Show resolved Hide resolved
@elianalf elianalf removed the needs-review PR that is ready to be reviewed label May 24, 2024
@elianalf elianalf force-pushed the feature/remove_miscellaneous_api branch from 7cb1a23 to b75b28b Compare May 24, 2024 11:29
@elianalf elianalf requested a review from EduPonz May 24, 2024 11:30
@github-actions github-actions bot added the ci-pending PR which CI is running label May 24, 2024
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 24, 2024 12:37
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@elianalf elianalf force-pushed the feature/remove_miscellaneous_api branch from 529e765 to 8c22d90 Compare May 29, 2024 06:47
@elianalf elianalf requested review from EduPonz and removed request for EduPonz May 29, 2024 06:47
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 29, 2024
@EduPonz EduPonz merged commit 356cc96 into master May 30, 2024
10 of 11 checks passed
@EduPonz EduPonz deleted the feature/remove_miscellaneous_api branch May 30, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants