-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20817] Remove unnecessary header and make private SecurityException and Exception #4701
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elianalf
changed the title
Remove unnecessary header and make private SecurityException and Exception
[20817] Remove unnecessary header and make private SecurityException and Exception
Apr 18, 2024
EduPonz
force-pushed
the
3.0.x-devel
branch
3 times, most recently
from
April 23, 2024 05:52
5148f5d
to
bd83bb2
Compare
EduPonz
force-pushed
the
3.0.x-devel
branch
2 times, most recently
from
May 13, 2024 09:26
08ee62b
to
623db82
Compare
elianalf
force-pushed
the
feature/remove_miscellaneous_api
branch
from
May 16, 2024 14:56
8ed9e38
to
7cb1a23
Compare
EduPonz
suggested changes
May 24, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small NIT. Also, this has conflicts now, please rebase. It seems that ShapesDemo does not build with this, neither does Fast DDS Python
elianalf
force-pushed
the
feature/remove_miscellaneous_api
branch
from
May 24, 2024 11:29
7cb1a23
to
b75b28b
Compare
6 tasks
@richiprosima please test_3 this |
6 tasks
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
Signed-off-by: elianalf <[email protected]>
elianalf
force-pushed
the
feature/remove_miscellaneous_api
branch
from
May 29, 2024 06:47
529e765
to
8c22d90
Compare
elianalf
added
ready-to-merge
Ready to be merged. CI and changes have been reviewed and approved.
and removed
ci-pending
PR which CI is running
labels
May 29, 2024
EduPonz
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR
Remove:
Make private:
Move the implementation of LoggingLevel to .cpp in /src
Related PR
Contributor Checklist
versions.md
file (if applicable).- Related documentation PR: [20817] Remove exception api Fast-DDS-docs#785
Reviewer Checklist