Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20708] Make NetworkConfiguration private #4671

Merged
merged 1 commit into from
May 17, 2024
Merged

[20708] Make NetworkConfiguration private #4671

merged 1 commit into from
May 17, 2024

Conversation

JesusPoderoso
Copy link
Contributor

@JesusPoderoso JesusPoderoso commented Apr 8, 2024 •
edited by elianalf
Loading

Description

This PR makes NetworkConfiguration private

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@JesusPoderoso JesusPoderoso added this to the v3.0.0 milestone Apr 8, 2024
@elianalf elianalf self-requested a review April 10, 2024 07:22
@github-actions github-actions bot added the ci-pending PR which CI is running label Apr 10, 2024
@elianalf
Copy link
Contributor

@richiprosima please test_3 this

elianalf
elianalf approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@elianalf elianalf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with Green CI

@JesusPoderoso JesusPoderoso force-pushed the feature/make_private_NetworkConfiguration branch from aa97182 to 43d9878 Compare April 17, 2024 15:04
@JesusPoderoso JesusPoderoso requested a review from elianalf April 17, 2024 15:04
@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 8c0830d to 5148f5d Compare April 18, 2024 13:07
@JesusPoderoso JesusPoderoso force-pushed the feature/make_private_NetworkConfiguration branch 2 times, most recently from 4b37fc0 to 89459b3 Compare April 18, 2024 13:09
@JesusPoderoso JesusPoderoso force-pushed the feature/make_private_NetworkConfiguration branch from 89459b3 to 170d7d3 Compare April 24, 2024 10:54
@JesusPoderoso JesusPoderoso requested review from elianalf and removed request for elianalf April 25, 2024 05:45
@elianalf
Copy link
Contributor

elianalf commented May 6, 2024

@richiprosima please test_3 this

elianalf
elianalf previously approved these changes May 6, 2024
View reviewed changes
@elianalf
Copy link
Contributor

elianalf commented May 7, 2024

@richiprosima please test_3 mac

1 similar comment
@elianalf
Copy link
Contributor

elianalf commented May 7, 2024

@richiprosima please test_3 mac

@EduPonz EduPonz force-pushed the 3.0.x-devel branch 2 times, most recently from 08ee62b to 623db82 Compare May 13, 2024 09:26
@EduPonz EduPonz deleted the branch master May 14, 2024 07:22
@EduPonz EduPonz closed this May 14, 2024
@EduPonz EduPonz reopened this May 14, 2024
@EduPonz EduPonz changed the base branch from 3.0.x-devel to master May 14, 2024 07:28
@EduPonz EduPonz dismissed elianalf’s stale review May 14, 2024 07:28

The base branch was changed.

@JesusPoderoso JesusPoderoso force-pushed the feature/make_private_NetworkConfiguration branch from 170d7d3 to 8e25020 Compare May 14, 2024 07:32
@JesusPoderoso
Copy link
Contributor Author

@richiprosima please test_3 this

@JesusPoderoso JesusPoderoso requested a review from elianalf May 14, 2024 07:56
@elianalf elianalf added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 16, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 16, 2024
@elianalf elianalf force-pushed the feature/make_private_NetworkConfiguration branch from 8e25020 to 646ce97 Compare May 16, 2024 13:30
@elianalf elianalf self-requested a review May 16, 2024 13:30
@elianalf
Copy link
Contributor

@richiprosima please test_3 this

@elianalf elianalf removed the ci-pending PR which CI is running label May 17, 2024
@elianalf elianalf force-pushed the feature/make_private_NetworkConfiguration branch from 646ce97 to 3bb1957 Compare May 17, 2024 09:45
@elianalf
Copy link
Contributor

@richiprosima please test_3 linux

@EduPonz EduPonz merged commit 28c72b1 into master May 17, 2024
4 checks passed
@EduPonz EduPonz deleted the feature/make_private_NetworkConfiguration branch May 17, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elianalf elianalf elianalf approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@JesusPoderoso @elianalf @EduPonz