-
Notifications
You must be signed in to change notification settings - Fork 787
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20575] Examples refactor: Configuration #4570
Conversation
1f2e8b7
to
30d4fcd
Compare
c534f32
to
b83c0ac
Compare
b83c0ac
to
90c3c52
Compare
2a521df
to
1906de7
Compare
18d8c6e
to
f3b3af6
Compare
eb6ba0c
to
5d12211
Compare
|
112656b
to
64e1e33
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really good job with this PR, bringing a helpful configuration example refactor. I love the example testing automation.
Leaving some suggestions to review.
@richiprosima please test_3 windows |
@richiprosima please test_3 linux |
@richiprosima test windows |
6b2eab7
to
704190d
Compare
@richiprosima please test_3 linux please test_3 windows |
@JesusPoderoso would you mind rebasing so that Ubuntu CI and Docs pass CI ? |
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
Signed-off-by: JesusPoderoso <[email protected]>
704190d
to
7e56555
Compare
@richiprosima please test_3 this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM !
Description
This PR is part of a suite of PR which would make a refactor in the repository examples.
It is intended to apply to most of the examples, by making them homogeneous, more understandable, and more specific to the case they were meant to be.
In this configuration example, the key changes are:
The following changes apply to this and the remain examples:
Contributor Checklist
versions.md
file (if applicable).Reviewer Checklist