Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[18728] Add TypeLookup settings into XML parser #3547

Merged
merged 4 commits into from
Jun 1, 2023

Conversation

JLBuenoLopez
Copy link
Contributor

@JLBuenoLopez JLBuenoLopez commented May 29, 2023

Description

BuiltinAttributes allows to configure the TypeLookupService builtin endpoints. This structure is accessible through the WireProtocolConfigQos but it is not possible to set this configuration using an XML file. This PR adds support to configure the TypeLookupService builtin endpoints using XML files.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • [N/A] Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • [N/A] New feature has been added to the versions.md file (if applicable).
  • New feature has been documented/Current behavior is correctly described in the documentation.
    Related documentation PR: [18728] Support typelookupservice settings in XML Fast-DDS-docs#498 (PR)
  • [N/A] Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

rsanchez15 and others added 3 commits May 29, 2023 10:12
@JesusPoderoso
Copy link
Contributor

@JLBuenoLopez-eProsima for XML validation test, could you include the XML snippet in the domain participant configured in the following files?

  • test/system/tools/xmlvalidation/domainParticipant_profile.xml
  • test/system/tools/xmlvalidation/all_profile.xml

Thanks!

snippet:

<typelookup_config>
    <use_client>true</use_client>
    <use_server>true</use_server>
</typelookup_config>

…nto XML files used for validation

Signed-off-by: JLBuenoLopez-eProsima <[email protected]>
@JLBuenoLopez
Copy link
Contributor Author

@richiprosima please test this

@JLBuenoLopez JLBuenoLopez added the ci-pending PR which CI is running label May 31, 2023
@JesusPoderoso JesusPoderoso added this to the v2.11.0 milestone May 31, 2023
@JLBuenoLopez JLBuenoLopez added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. labels Jun 1, 2023
@JLBuenoLopez JLBuenoLopez merged commit 8644a04 into master Jun 1, 2023
@JLBuenoLopez JLBuenoLopez deleted the feature/typelookup-config-xml branch June 1, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants