Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Print output Dynamic Types inline #3484

Merged
merged 5 commits into from
May 25, 2023
Merged

Print output Dynamic Types inline #3484

merged 5 commits into from
May 25, 2023

Conversation

irenebm
Copy link
Contributor

@irenebm irenebm commented Apr 24, 2023 •
edited by JesusPoderoso
Loading

Description

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • Changes are ABI compatible.
  • Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

irenebm added 4 commits April 24, 2023 14:05
@irenebm
Add output to string
1b867e9 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
API compatible
5f6549a 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Uncrustify
d0ff7bc 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm
Change std::string to std::ostream&
d2c9e92 
Signed-off-by: Irene Bandera <[email protected]>
@irenebm irenebm marked this pull request as ready for review April 25, 2023 12:55
@JLBuenoLopez JLBuenoLopez added this to the v2.11.0 milestone May 8, 2023
@JesusPoderoso
Copy link
Contributor

Hi @irenebm, can you fix the uncrustify issue?

Then we can run the CI and go ahead with the PR.

@JesusPoderoso JesusPoderoso added needs-review PR that is ready to be reviewed in progress Issue or PR which is being reviewed ci-pending PR which CI is running labels May 18, 2023
@irenebm
Uncrustify
2a4e3b6 
Signed-off-by: Irene Bandera <[email protected]>
@JesusPoderoso
Copy link
Contributor

@richiprosima please test this

@JesusPoderoso JesusPoderoso removed the in progress Issue or PR which is being reviewed label May 18, 2023
@Mario-DL Mario-DL added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed needs-review PR that is ready to be reviewed ci-pending PR which CI is running labels May 24, 2023
@JesusPoderoso
Copy link
Contributor

@richiprosima please test mac

JesusPoderoso
JesusPoderoso approved these changes May 25, 2023
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MiguelCompany MiguelCompany merged commit 23be906 into master May 25, 2023
@MiguelCompany MiguelCompany deleted the feature/dynamic-print branch May 25, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso JesusPoderoso approved these changes

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v2.11.0
Development

Successfully merging this pull request may close these issues.
5 participants
@irenebm @JesusPoderoso @MiguelCompany @JLBuenoLopez @Mario-DL