[20256] Reject old samples #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsanchez15
previously approved these changes
Mar 4, 2024
rsanchez15
force-pushed
the
bugfix/reject_old_samples
branch
from
18eaa35 to
29b51e6
Compare
Carlosespicur
previously approved these changes
Dec 9, 2024
Signed-off-by: Jesus Perez <[email protected]>
Signed-off-by: Jesus Perez <[email protected]>
Signed-off-by: Jesus Perez <[email protected]>
Carlosespicur
force-pushed
the
bugfix/reject_old_samples
branch
from
5809ae2 to
7bf1ab4
Compare
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
…rrors Signed-off-by: Carlosespicur <[email protected]>
Carlosespicur
force-pushed
the
bugfix/reject_old_samples
branch
from
2eb7826 to
55397ee
Compare
Carlosespicur
temporarily deployed
to
codecov
GitHub Actions
Inactive
depink5
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a DDS Router, since statistics writers are transient local, previously processed samples might be delivered again to statistics backend participants in other domains. This lead to crashes since new delivered count samples (transient local - late joiner) got lower values than the last processed.
With this PR we are rejecting old samples